Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding cosmics path for HLT validation (106X) #28126

Merged
merged 1 commit into from Oct 23, 2019

Conversation

Martin-Grunewald
Copy link
Contributor

PR description:

Adding cosmics path for HLT validation (106X)
Based on CMSSW_10_6_X_2019-10-06-2300.

PR validation:

TSG tests

if this PR is a backport please specify the original PR:

#28125

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_10_6_X.

It involves the following packages:

HLTrigger/Configuration

@Martin-Grunewald, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @geoff-smith this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor Author

backport of #28125

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2832/console Started: 2019/10/08 11:26

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7f1fd/2832/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212034
  • DQMHistoTests: Total failures: 47
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211653
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.656 KiB( 32 files compared)
  • DQMHistoSizes: changed ( 136.85,... ): 0.164 KiB HLT/GeneralHLTOffline
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@Martin-Grunewald
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a72d40e into cms-sw:CMSSW_10_6_X Oct 23, 2019
@Martin-Grunewald Martin-Grunewald deleted the HLTcosmics106X branch October 27, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants