Make Process.prune() to prune also Tasks, and add --prune option to edmConfigDump

[makortel]

PR description:

This PR is a (partial) follow-up on issue #28172. In addition to the title, this PR makes edmConfigDump to use ArgumentParser and print_function.

PR validation:

Unit tests run.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28173/12245

• This PR adds an extra 40KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/ParameterSet/python/Config.py modified in PR(s): Add a script to split a CMSSW configuration into individual cfi files #27305

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

FWCore/ParameterSet

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2931/console Started: 2019/10/14 22:30

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[wddgit]

I did not carefully read the code. This is a question. Does this account for the fact that a Task can be associated with the Schedule as an alternative to associating it with a Path, EndPath, or Sequence?

[makortel]

I did not carefully read the code. This is a question. Does this account for the fact that a Task can be associated with the Schedule as an alternative to associating it with a Path, EndPath, or Sequence?

Thanks David, that fact is not accounted for (and need to be fixed). I'll abort the tests to prevent accidental "fully signed".

[makortel]

@cmsbuild, please abort

[cmsbuild]

Jenkins tests are aborted.

[fabiocos]

@makortel thanks, I see that you have updated edmConfigDump so as to be compatible with python3, I was about to do the same in order to validate the fix for DataProcessing

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28173/12325

• This PR adds an extra 56KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/ParameterSet/python/Config.py modified in PR(s): Add a script to split a CMSSW configuration into individual cfi files #27305
  • File FWCore/ParameterSet/python/SequenceTypes.py modified in PR(s): Add a script to split a CMSSW configuration into individual cfi files #27305

[cmsbuild]

Pull request #28173 was updated. @cmsbuild, @smuzaffar, @Dr15Jones can you please check and sign again.

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3026/console Started: 2019/10/18 16:30

[cmsbuild]

-1

Tested at: 532ed63

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ae396d/3026/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test EcalTPGFineGrainEBIdMap_O2O_test had ERRORS
---> test EcalTPGPhysicsConst_O2O_test had ERRORS
---> test EcalLaser_O2O_test had ERRORS
---> test EcalTPGWeightIdMap_O2O_test had ERRORS
---> test EcalDAQ_O2O_test had ERRORS
---> test EcalDCS_O2O_test had ERRORS
---> test EcalTPGFineGrainTowerEE_O2O_test had ERRORS
---> test EcalTPGFineGrainEBGroup_O2O_test had ERRORS
---> test EcalIntercalibConstants_O2O_test had ERRORS
---> test SiStripDCS_O2O_test had ERRORS

[cmsbuild]

Comparison job queued.

[Dr15Jones]

+1
the unit test failures are unrelated to this pull request

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ae396d/3026/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2961064
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2960721
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[fabiocos]

+1

[fabiocos]

merge