ECAL for Time dependent MC. Premix option C. Handle for APD/PN tag for time dependence

[amassiro]

First implementation of the ECAL run dependent MC
Similar to #27970, but that was in 10_6_X
Similar to #27974, but after an email exchange with db experts some of the issues from previous PR have been fixed.

To be tested it needs this PR: #27649

Physics details in the presentation at ECAL DPG here: https://indico.cern.ch/event/847097/

This PR will affect only the mixing step, when the premixed library is mixed with the hard scattering. The idea is that the pileup response, that has been simulated with a given transparency for ECAL crystals, will be scaled to match the transparency of the corresponding IOV.
A new object is introduced ( EcalLaserAPDPNRatiosMCRcd ), that has 1 single IOV, thus allowing this to be used as reference for scaling.
Goal: correct simulation of the photostatistics for pileup, when producing run dependent MC with several IOVs (main changes in run dependent MC for ECAL are transparency and noise).

This PR is needed for testing via relval, checking physics performance and possibly imploved data-MC comparison.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28214/12331

• This PR adds an extra 76KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CalibCalorimetry/EcalLaserCorrection/interface/EcalLaserDbRecordMC.h modified in PR(s): Premix option c, with 2 tags, ECAL, 11_0_X #27974
  • File CalibCalorimetry/EcalLaserCorrection/plugins/EcalLaserCorrectionServiceMC.cc modified in PR(s): Premix option c, with 2 tags, ECAL, 11_0_X #27974
  • File CalibCalorimetry/EcalLaserCorrection/src/EcalLaserDbRecordMC.cc modified in PR(s): Premix option c, with 2 tags, ECAL, 11_0_X #27974
  • File CondCore/EcalPlugins/src/plugin.cc modified in PR(s): Premix option c, with 2 tags, ECAL, 11_0_X #27974
  • File CondFormats/DataRecord/interface/EcalLaserAPDPNRatiosMCRcd.h modified in PR(s): Premix option c, with 2 tags, ECAL, 11_0_X #27974
  • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983, DQM Sequence central clean up #28156
  • File SimCalorimetry/EcalSimAlgos/interface/EcalSignalGenerator.h modified in PR(s): Premix option c, with 2 tags, ECAL, 11_0_X #27974
  • File SimCalorimetry/EcalSimAlgos/src/EcalSignalGenerator.cc modified in PR(s): Premix option c, with 2 tags, ECAL, 11_0_X #27974

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28214/12331/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28214/12331/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28214/12332

• This PR adds an extra 80KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CalibCalorimetry/EcalLaserCorrection/interface/EcalLaserDbRecordMC.h modified in PR(s): Premix option c, with 2 tags, ECAL, 11_0_X #27974
  • File CalibCalorimetry/EcalLaserCorrection/plugins/EcalLaserCorrectionServiceMC.cc modified in PR(s): Premix option c, with 2 tags, ECAL, 11_0_X #27974
  • File CalibCalorimetry/EcalLaserCorrection/src/EcalLaserDbRecordMC.cc modified in PR(s): Premix option c, with 2 tags, ECAL, 11_0_X #27974
  • File CondCore/EcalPlugins/src/plugin.cc modified in PR(s): Premix option c, with 2 tags, ECAL, 11_0_X #27974
  • File CondFormats/DataRecord/interface/EcalLaserAPDPNRatiosMCRcd.h modified in PR(s): Premix option c, with 2 tags, ECAL, 11_0_X #27974
  • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983, DQM Sequence central clean up #28156
  • File SimCalorimetry/EcalSimAlgos/interface/EcalSignalGenerator.h modified in PR(s): Premix option c, with 2 tags, ECAL, 11_0_X #27974
  • File SimCalorimetry/EcalSimAlgos/src/EcalSignalGenerator.cc modified in PR(s): Premix option c, with 2 tags, ECAL, 11_0_X #27974

[cmsbuild]

+1
Tested at: e4810f5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c4e95/4161/summary.html
CMSSW: CMSSW_11_1_X_2020-01-07-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c4e95/4161/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2815513
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2815165
• DQMHistoTests: Total skipped: 346
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[silviodonato]

alca: @christopheralanwest @franzoni @tlampen @pohsun @tocheng
db: @ggovi
simulation: @mdhildreth @civanch
upgrade: @kpedro88
please review/sign

[kpedro88]

+upgrade

[civanch]

+1

[christopheralanwest]

+1

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1