Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix electron PFCandidates RefVector usage in MuonFSRProducer #28221

Merged
merged 1 commit into from Oct 22, 2019
Merged

Fix electron PFCandidates RefVector usage in MuonFSRProducer #28221

merged 1 commit into from Oct 22, 2019

Conversation

peruzzim
Copy link
Contributor

@peruzzim peruzzim commented Oct 20, 2019

PR description:

This PR fixes the issue reported by @Dr15Jones in #28118 (review)

Should be backported to 102X and 106X.

PR validation:

Tested on one file, it runs. The code change is pretty minimal.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28221/12348

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @peruzzim for master.

It involves the following packages:

MuonAnalysis/MuonAssociators

@cmsbuild, @santocch can you please review it and eventually sign? Thanks.
@bellan, @abbiendi, @Fedespring, @calderona, @HuguesBrun, @jhgoh, @battibass, @cericeci, @trocino, @folguera this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@peruzzim
Copy link
Contributor Author

please test workflow 1325.6,1325.7,1325.8,1329.1,136.7722,136.7952,136.8521

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 20, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3041/console Started: 2019/10/20 23:45

@Dr15Jones
Copy link
Contributor

Thanks!

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf9882/3041/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2961064
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2960722
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@fabiocos
Copy link
Contributor

@peruzzim did you explicitly verified the output of this fix?

@peruzzim
Copy link
Contributor Author

The tests here show no difference, in addition I've done a full set of tests in the nanoAOD suite (cms-nanoAOD#442), all tests successful and no change observed.
Actually the code issue would only lead to (potentially) getting stuck in the for loop and getting past the end of the vector with the iterator, I don't see a way it could change the results.

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 5aafe91 into cms-sw:master Oct 22, 2019
@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants