Fix for gcc9 warning in HLTrigger/JSONMonitoring #28274

mrodozov · 2019-10-25T15:21:18Z

PR description:

Fixes
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc900/CMSSW_11_0_X_2019-10-24-2300/HLTrigger/JSONMonitoring

PR validation:

Compile without warning

Fixes https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc900/CMSSW_11_0_X_2019-10-24-2300/HLTrigger/JSONMonitoring

mrodozov · 2019-10-25T15:21:24Z

please test

cmsbuild · 2019-10-25T15:23:55Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-10-25T15:29:52Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28274/12447

This PR adds an extra 16KB to repository

cmsbuild · 2019-10-25T15:30:18Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3167/console Started: 2019/10/25 17:31

cmsbuild · 2019-10-25T15:30:19Z

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

HLTrigger/JSONMonitoring

@Martin-Grunewald, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

fwyzard · 2019-10-25T15:37:31Z

HLTrigger/JSONMonitoring/plugins/L1TriggerJSONMonitoring.cc

@@ -41,7 +41,7 @@ struct L1TriggerJSONMonitoringData {
    std::vector<unsigned int> l1tAcceptCalibration;  // number of "calibration" events accepted by each L1 trigger
    std::vector<unsigned int> l1tAcceptRandom;       // number of "random" events accepted by each L1 trigger
    std::vector<unsigned int> tcdsAccept;  // number of "physics", "calibration", "random" and other event types
-    int prescaleIndex;                     // prescale column index
+    int prescaleIndex = {};                // prescale column index


This is supposed to be uninitialised here, since it is initialised before its first use.

If there is any suspicion that it is used uninitialised, then it should be initialised to kPrescaleUndefined, not 0.
Then, it would make sense to initialise also:

stream.processed = 0; lumisection.prescaleIndex = kPrescaleUndefined;

kPrescaleUndefined was not defined in that scope (which I blindly tried and now it doesn't compile). would you suggest the change please, I'll commit it :/

cmsbuild · 2019-10-25T15:51:19Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-10-25T15:55:38Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28274/12453

This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28274/12453/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28274/12453/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2019-10-25T16:55:02Z

+1
Tested at: c0f05de
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49e8f1/3167/summary.html

cmsbuild · 2019-10-25T16:55:06Z

Comparison job queued.

cmsbuild · 2019-10-25T18:38:20Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49e8f1/3167/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2961036
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2960694
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

cmsbuild · 2019-10-30T11:26:20Z

The code-checks are being triggered in jenkins.

mrodozov · 2019-10-30T11:30:16Z

please test
lets see if this works :)

cmsbuild · 2019-10-30T11:31:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28274/12538

This PR adds an extra 20KB to repository

cmsbuild · 2019-10-30T11:32:08Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3244/console Started: 2019/10/30 12:38

cmsbuild · 2019-10-30T11:32:10Z

Pull request #28274 was updated. @Martin-Grunewald, @cmsbuild, @fwyzard can you please check and sign again.

cmsbuild · 2019-10-30T12:57:35Z

+1
Tested at: 36043c9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49e8f1/3244/summary.html

cmsbuild · 2019-10-30T12:57:38Z

Comparison job queued.

fwyzard · 2019-10-30T13:32:25Z

lets see if this works :)

thanks for the changes !

cmsbuild · 2019-10-30T15:42:34Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49e8f1/3244/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2961036
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2960694
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

fabiocos · 2019-11-03T09:24:30Z

@Martin-Grunewald is this fix ok to be integrated?

Martin-Grunewald · 2019-11-04T09:03:12Z

+1

cmsbuild · 2019-11-04T09:03:40Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-11-04T20:49:57Z

+1

Fix for gcc9 warning in HLTrigger/JSONMonitoring

c0f05de

Fixes https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc900/CMSSW_11_0_X_2019-10-24-2300/HLTrigger/JSONMonitoring

cmsbuild added this to the CMSSW_11_0_X milestone Oct 25, 2019

cmsbuild added code-checks-pending comparison-pending hlt-pending orp-pending pending-signatures tests-pending labels Oct 25, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 25, 2019

cmsbuild added tests-started and removed tests-pending labels Oct 25, 2019

fwyzard suggested changes Oct 25, 2019

View reviewed changes

Update L1TriggerJSONMonitoring.cc

a1a5d9f

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-started labels Oct 25, 2019

cmsbuild added code-checks-rejected and removed code-checks-pending labels Oct 25, 2019

cmsbuild added the tests-pending label Oct 30, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 30, 2019

cmsbuild added tests-started and removed tests-pending labels Oct 30, 2019

cmsbuild added tests-approved and removed tests-started labels Oct 30, 2019

cmsbuild added comparison-available and removed comparison-pending labels Oct 30, 2019

cmsbuild added fully-signed hlt-approved and removed hlt-pending pending-signatures labels Nov 4, 2019

cmsbuild added orp-approved and removed orp-pending labels Nov 4, 2019

cmsbuild merged commit c8a93fa into cms-sw:master Nov 4, 2019

cmsbuild mentioned this pull request Nov 5, 2019

Apply code formatting to FWCore/Framework #28345

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for gcc9 warning in HLTrigger/JSONMonitoring #28274

Fix for gcc9 warning in HLTrigger/JSONMonitoring #28274

mrodozov commented Oct 25, 2019

mrodozov commented Oct 25, 2019

cmsbuild commented Oct 25, 2019

cmsbuild commented Oct 25, 2019

cmsbuild commented Oct 25, 2019 •

edited

cmsbuild commented Oct 25, 2019

fwyzard Oct 25, 2019 •

edited

mrodozov Oct 25, 2019 •

edited

cmsbuild commented Oct 25, 2019

cmsbuild commented Oct 25, 2019

cmsbuild commented Oct 25, 2019

cmsbuild commented Oct 25, 2019

cmsbuild commented Oct 25, 2019

cmsbuild commented Oct 30, 2019

mrodozov commented Oct 30, 2019

cmsbuild commented Oct 30, 2019

cmsbuild commented Oct 30, 2019 •

edited

cmsbuild commented Oct 30, 2019

cmsbuild commented Oct 30, 2019

cmsbuild commented Oct 30, 2019

fwyzard commented Oct 30, 2019

cmsbuild commented Oct 30, 2019

fabiocos commented Nov 3, 2019

Martin-Grunewald commented Nov 4, 2019

cmsbuild commented Nov 4, 2019

fabiocos commented Nov 4, 2019

Fix for gcc9 warning in HLTrigger/JSONMonitoring #28274

Fix for gcc9 warning in HLTrigger/JSONMonitoring #28274

Conversation

mrodozov commented Oct 25, 2019

PR description:

PR validation:

mrodozov commented Oct 25, 2019

cmsbuild commented Oct 25, 2019

cmsbuild commented Oct 25, 2019

cmsbuild commented Oct 25, 2019 • edited

cmsbuild commented Oct 25, 2019

fwyzard Oct 25, 2019 • edited

Choose a reason for hiding this comment

mrodozov Oct 25, 2019 • edited

Choose a reason for hiding this comment

cmsbuild commented Oct 25, 2019

cmsbuild commented Oct 25, 2019

cmsbuild commented Oct 25, 2019

cmsbuild commented Oct 25, 2019

cmsbuild commented Oct 25, 2019

cmsbuild commented Oct 30, 2019

mrodozov commented Oct 30, 2019

cmsbuild commented Oct 30, 2019

cmsbuild commented Oct 30, 2019 • edited

cmsbuild commented Oct 30, 2019

cmsbuild commented Oct 30, 2019

cmsbuild commented Oct 30, 2019

fwyzard commented Oct 30, 2019

cmsbuild commented Oct 30, 2019

fabiocos commented Nov 3, 2019

Martin-Grunewald commented Nov 4, 2019

cmsbuild commented Nov 4, 2019

fabiocos commented Nov 4, 2019

cmsbuild commented Oct 25, 2019 •

edited

fwyzard Oct 25, 2019 •

edited

mrodozov Oct 25, 2019 •

edited

cmsbuild commented Oct 30, 2019 •

edited