Update to correct modeling of neutral density filter in HB and HE

[christopheralanwest]

PR description:

The modeling of the neutral density filters in HB and HE has been updated [1]. The geometry update includes the requested change to the full 2021 geometry [2]. The geometry updates changes light yields in depth=1, which are compensated by tuned HcalRespCorrs and HcalGains.

The GT diffs are as follows:

2021 design MC
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun3_2021_design_v4/110X_mcRun3_2021_design_v5
2021 realistic MC
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun3_2021_realistic_v4/110X_mcRun3_2021_realistic_v5
2021 realistic cosmic MC, with tracker in deco mode
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun3_2021cosmics_realistic_deco_v2/110X_mcRun3_2021cosmics_realistic_deco_v3
2023 realistic MC
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun3_2023_realistic_v4/110X_mcRun3_2023_realistic_v5
2024 realistic MC
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun3_2024_realistic_v4/110X_mcRun3_2024_realistic_v5

[1] https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4235.html
[2] https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4206/1.html

PR validation:

Validation by HCAL experts with a single-pion scan shows that the energy scale remains practically unchanged, except at low energy, where the observed small changes are consistent with expectations. See [1] for details. In addition, a technical test was performed: runTheMatrix.py -l 12024.0,11634.0,8.2,12434.0,12834.0.

[1] https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4235.html

if this PR is a backport please specify the original PR:

This is not a backport and should not be backported.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28307/12520

• This PR adds an extra 12KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/AlCa/python/autoCond.py modified in PR(s): Updated 2018 Strips MC conditions to improve data/MC agreement #28234, Use corrected PF cluster correction tags for 2018 design MC scenario #28263, [HBHE] Update MahiDebugger and fix nP in NNLS  #28193

[cmsbuild]

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

Configuration/AlCa

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[christopheralanwest]

please test workflow 12024.0,11634.0,8.2,12434.0,12834.0

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3232/console Started: 2019/10/29 21:53

[cmsbuild]

+1
Tested at: 68cfb15
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be873d/3232/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be873d/3232/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-be873d/12024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2021Design_GenSimFull+DigiFull_2021Design+RecoFull_2021Design+HARVESTFull_2021Design
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-be873d/8.2_BeamHalo_UP21+BeamHalo_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCABH_UP21+HARVESTCOS_UP21

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 5177 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2961036
• DQMHistoTests: Total failures: 18336
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2942359
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[christopheralanwest]

+1

• Changes validated in local tests
• Comparison tests show differences consistent with those seen in local tests: very small differences, which are somewhat larger at low energy. For example, see HBHE rechit energy in 2021 ttbar.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1