record for xtal-dependent seeding thresholds #28324
Conversation
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28324/12570
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28324/12625
|
|
A new Pull Request was created by @argiro for master. It involves the following packages: CondFormats/DataRecord @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@ggovi could you please have a look? |
|
+1 |
|
+1 |
|
@smuzaffar and here it looks the same happened as for #28327 ... I wonder whether there is any correlation with the fact that it is the same signature |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
@argiro for my understanding, on which time scale do you plan to add this new feature using the record of this PR? |
|
On 11 Nov 2019, at 15:55, Fabio Cossutti ***@***.***> wrote:
@argiro for my understanding, on which time scale do you plan to add this new feature using the record of this PR?
say by the end of the month. Is MSSW_11_0_0_pre13: 2019/11/19 a hard deadline ?
…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
@fabiocos , looks like some glitch with CERN network. Github was not able to deliver the webhook because |
|
@fabiocos , I have setup cms-bot to also pool every 30mins to re-process recently updated (with in 60mins) PRs. This will allow to deal with such glitches |
|
@smuzaffar thanks, this may be helpful in cases like this |
|
@argiro if the development to use this PR needs to be in 11_0_0 for HLT TDR initial production it should be there by the closure of the development (unless this is revisited for updated needs) |
|
+1 |
|
thanks Fabio, it is not needed for HLT TDR
… On 11 Nov 2019, at 18:18, Fabio Cossutti ***@***.***> wrote:
@argiro if the development to use this PR needs to be in 11_0_0 for HLT TDR initial production it should be there by the closure of the development (unless this is revisited for updated needs)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
PR description:
A new feature is planned in PF reconstruction, whereby seeding is made using xtal-dependent thresholds. This PR is to introduce the new record that provides the thresholds, so that the DB can be populated and the new feature introduced later.
PR Validation:
N/A