New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-sim48 First step to remove access of DDCompactView in SimG4CMS/Calo for ECAL #28327
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28327/12579
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
@cmsbuild Please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28327/12581
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @bsunanda for master. It involves the following packages: CondFormats/GeometryObjects @civanch, @Dr15Jones, @cvuosalo, @christopheralanwest, @ianna, @mdhildreth, @cmsbuild, @franzoni, @tocheng, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
Comparison job queued. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
@fabiocos @christopheralanwest @ggovi @tocheng Can this PR move quickly? Have to work on the next step |
+1 |
@ggovi please check, I would like to close this PR asap |
+1 |
@smuzaffar apparently the bot missed the signature of @ggovi I will retain it as good of course and merge this PR this evening |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Create objects for ECAL which are needed at SIM step from specpar etc so that SIM step does not require access to DDCompactView and can use this object. The change in SIM step to be done in the next step
PR validation:
Tested with standard workflows
if this PR is a backport please specify the original PR:
Nothing special