Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-sim48 First step to remove access of DDCompactView in SimG4CMS/Calo for ECAL #28327

Merged
merged 4 commits into from Nov 11, 2019

Conversation

bsunanda
Copy link
Contributor

PR description:

Create objects for ECAL which are needed at SIM step from specpar etc so that SIM step does not require access to DDCompactView and can use this object. The change in SIM step to be done in the next step

PR validation:

Tested with standard workflows

if this PR is a backport please specify the original PR:

Nothing special

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28327/12579

  • This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28327/12581

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 31, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3290/console Started: 2019/10/31 21:59

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

CondFormats/GeometryObjects
Geometry/EcalCommonData
SimG4CMS/Calo

@civanch, @Dr15Jones, @cvuosalo, @christopheralanwest, @ianna, @mdhildreth, @cmsbuild, @franzoni, @tocheng, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @mmusich, @seemasharmafnal, @tocheng, @argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f7a68/3376/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2936360
  • DQMHistoTests: Total failures: 26
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2935993
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@ianna
Copy link
Contributor

ianna commented Nov 8, 2019

+1

@civanch
Copy link
Contributor

civanch commented Nov 8, 2019

+1

@bsunanda
Copy link
Contributor Author

bsunanda commented Nov 8, 2019

@fabiocos @christopheralanwest @ggovi @tocheng Can this PR move quickly? Have to work on the next step

@christopheralanwest
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

@ggovi please check, I would like to close this PR asap

@ggovi
Copy link
Contributor

ggovi commented Nov 11, 2019

+1

@fabiocos
Copy link
Contributor

@smuzaffar apparently the bot missed the signature of @ggovi I will retain it as good of course and merge this PR this evening

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d4a841f into cms-sw:master Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants