Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PY3] fixed unit tests for python3 IBs #28344

Merged
merged 2 commits into from Nov 5, 2019
Merged

[PY3] fixed unit tests for python3 IBs #28344

merged 2 commits into from Nov 5, 2019

Conversation

smuzaffar
Copy link
Contributor

This should fix 3 unit tests for python3 IBs

  • cjson: It is python2 package only, so run it under python2
  • ordereddict: It is python2 package only, so run it under python2
  • ipython and ipython3: Added separate unit tests to test ipython and ipython3

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28344/12616

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3333/console Started: 2019/11/04 20:34

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2019

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

PhysicsTools/PythonAnalysis

@cmsbuild, @santocch can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28344/12617

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3334/console Started: 2019/11/04 20:42

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2019

Pull request #28344 was updated. @cmsbuild, @santocch can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8cec9b/3334/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2939026
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2938684
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor Author

@santocch , can you please review it. It is just a technical change to fix these unit tests for PY3 IBs.

@fabiocos
Copy link
Contributor

fabiocos commented Nov 5, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented Nov 5, 2019

merge

@santocch this looks technical and straightforward

@cmsbuild cmsbuild merged commit 0cf6bc9 into cms-sw:master Nov 5, 2019
@santocch
Copy link

santocch commented Nov 8, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants