Move Sequence to Task for RecoTauTag RecoCTPPS #28399
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28399/12757
|
|
A new Pull Request was created by @jeongeun (JeongEun Lee) for master. It involves the following packages: RecoCTPPS/PixelLocal @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
| ckfTracksFromConversionsReRecoTask = cms.Task(conversionTrackCandidates, | ||
| ckfOutInTracksFromConversions, | ||
| ckfInOutTracksFromConversions) | ||
| ckfTracksFromConversionsReReco = cms.Sequence(ckfTracksFromConversionsReRecoTask) |
There was a problem hiding this comment.
This is only used here internally: no need to define the sequence
| inOutConversionTrackProducerReReco, | ||
| outInConversionTrackProducerReReco, | ||
| gsfConversionTrackProducerReReco) | ||
| conversionTrackProducersReReco = cms.Sequence(conversionTrackProducersReRecoTask) |
There was a problem hiding this comment.
This is only used here internally: no need to define the sequence
| generalConversionStepConversionTrackMergerReReco, | ||
| generalInOutOutInConversionTrackMergerReReco, | ||
| gsfGeneralInOutOutInConversionTrackMergerReReco) | ||
| conversionTrackMergersReReco = cms.Sequence(conversionTrackMergersReRecoTask) |
There was a problem hiding this comment.
This is only used here internally: no need to define the sequence
| eleIsoDepositHcalDepth2FromTowers | ||
| ) | ||
|
|
||
| eleIsoDeposits = cms.Sequence(eleIsoDepositsTask) |
There was a problem hiding this comment.
This is only used in RecoEgamma/EgammaIsolationAlgos/python/eleIsolationSequence_cff.py: maybe one could avoid defining explicitly the sequence here
| eleIsoFromDepsHcalDepth2FromTowers | ||
| ) | ||
|
|
||
| eleIsoFromDeposits = cms.Task(eleIsoFromDepositsTask) |
There was a problem hiding this comment.
This is only used in RecoEgamma/EgammaIsolationAlgos/python/eleIsolationSequence_cff.py: maybe one could avoid defining explicitly the sequence here
| gamIsoDepositHcalDepth2FromTowers | ||
| ) | ||
|
|
||
| gamIsoDeposits = cms.Sequence(gamIsoDepositsTask) |
There was a problem hiding this comment.
This is only used in RecoEgamma/EgammaIsolationAlgos/python/gamIsolationSequence_cff.py: maybe one could avoid defining explicitly the sequence here
| gamIsoFromDepsHcalDepth2FromTowers | ||
| ) | ||
|
|
||
| gamIsoFromDeposits = cms.Sequence(gamIsoFromDepositsTask) |
There was a problem hiding this comment.
This is only used in RecoEgamma/EgammaIsolationAlgos/python/gamIsolationSequence_cff.py: maybe one could avoid defining explicitly the sequence here
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28399/12794
|
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1
|
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Move Sequence to Task for RecoTauTag RecoCTPPS cff python files.
(An extension of the previous task PR#25163, PR#27474 , PR#27640, PR#27887, PR#28050, PR#28300 )
Tested in CMSSW_11_0_X_2019_11-12-2300, the test all passed in the CMSSW PR instructions.