Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu migration to 1100pre12 template (PFProducer) #28406

Merged
merged 1 commit into from Nov 18, 2019

Conversation

Martin-Grunewald
Copy link
Contributor

PR description:

HLT menu migration to 1100pre12 template (PFProducer)
Based on CMSSW_11_0_0_pre12

PR validation:

TSG tests

if this PR is a backport please specify the original PR:

N/A

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@Martin-Grunewald
Copy link
Contributor Author

Fixes issue #28403

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28406/12776

  • This PR adds an extra 984KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for master.

It involves the following packages:

HLTrigger/Configuration

@Martin-Grunewald, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @geoff-smith this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 15, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3496/console Started: 2019/11/15 17:19

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2879f/3496/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2936234
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2935892
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@Martin-Grunewald
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@Martin-Grunewald I understand that the "frozen" 2018 menu keeps unchanged result, as this PR just moves a functionality between different parts of the configuration, am I correct?

@Martin-Grunewald
Copy link
Contributor Author

Indeed that is the plan. However, there may be residual changes due to updated PF parameters, but those changes are acceptable.

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8dbfd75 into cms-sw:master Nov 18, 2019
@Martin-Grunewald Martin-Grunewald deleted the HLTmigrationTo1100pre12 branch October 27, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants