New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix use of object after destructor in HcalHardcodeCalibrations #28413
Conversation
The temporarily created ESConsumesCollector is held by reference but goes away on that line (since the compiler does not know it must extend the lifetime of the object returned by setWhatProduced). The problem was found by the address sanitizer.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28413/12790
|
please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: CalibCalorimetry/HcalPlugins @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
type bug-fix |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The temporarily created ESConsumesCollector is held by reference but goes away on that line (since the compiler does not know it must extend the lifetime of the object returned by setWhatProduced).
The problem was found by the address sanitizer.
PR validation:
The code compiles.