Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of object after destructor in HcalHardcodeCalibrations #28413

Merged
merged 1 commit into from Nov 19, 2019

Conversation

Dr15Jones
Copy link
Contributor

PR description:

The temporarily created ESConsumesCollector is held by reference but goes away on that line (since the compiler does not know it must extend the lifetime of the object returned by setWhatProduced).

The problem was found by the address sanitizer.

PR validation:

The code compiles.

The temporarily created ESConsumesCollector is held by reference
but goes away on that line (since the compiler does not know it
must extend the lifetime of the object returned by setWhatProduced).
The problem was found by the address sanitizer.
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28413/12790

  • This PR adds an extra 16KB to repository

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 17, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3508/console Started: 2019/11/17 19:25

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

CalibCalorimetry/HcalPlugins

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

Here was the report:
https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc820/CMSSW_11_0_ASAN_X_2019-11-15-2300/pyRelValMatrixLogs/run/20434.103_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D41_GenSimHLBeamSpotFull14INPUT+DigiFullTriggerAging3000_2026D41+RecoFullGlobalAging3000_2026D41+HARVESTFullGlobal_2026D41/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D41_GenSimHLBeamSpotFull14INPUT+DigiFullTriggerAging3000_2026D41+RecoFullGlobalAging3000_2026D41+HARVESTFullGlobal_2026D41.log#/

=================================================================
==6252==ERROR: AddressSanitizer: stack-use-after-scope on address 0x7ffedc88fb70 at pc 0x2b8f29c30c96 bp 0x7ffedc88be00 sp 0x7ffedc88bdf8
READ of size 8 at 0x7ffedc88fb70 thread T0
    #0 0x2b8f29c30c95 in auto edm::ESConsumesCollector::consumesFrom<HBHEDarkening, HBHEDarkeningRecord>(edm::ESInputTag const&amp) (/cvmfs/cms-ib.cern.ch/nweek-02602/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_ASAN_X_2019-11-15-2300/lib/slc7_amd64_gcc820/pluginCalibCalorimetryHcalPlugins.so+0x2f0c95)
    #1 0x2b8f29b18ade in HcalHardcodeCalibrations::HcalHardcodeCalibrations(edm::ParameterSet const&amp) (/cvmfs/cms-ib.cern.ch/nweek-02602/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_ASAN_X_2019-11-15-2300/lib/slc7_amd64_gcc820/pluginCalibCalorimetryHcalPlugins.so+0x1d8ade)
[cut]

Address 0x7ffedc88fb70 is located in stack of thread T0 at offset 13344 in frame
    #0 0x2b8f29b0fa5f in HcalHardcodeCalibrations::HcalHardcodeCalibrations(edm::ParameterSet const&amp) (/cvmfs/cms-ib.cern.ch/nweek-02602/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_0_ASAN_X_2019-11-15-2300/lib/slc7_amd64_gcc820/pluginCalibCalorimetryHcalPlugins.so+0x1cfa5f)

@Dr15Jones
Copy link
Contributor Author

type bug-fix

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f32d9/3508/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2936360
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2936017
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@tlampen
Copy link
Contributor

tlampen commented Nov 18, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit cae636c into cms-sw:master Nov 19, 2019
@Dr15Jones Dr15Jones deleted the fixHcalHardcodeCalibrations branch November 25, 2019 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants