remove MTD 'fastsim' modules

[kpedro88]

PR description:

This PR removes CPU-heavy 4D vertexing modules that use the MTD 'fastsim' time smearing (not to be confused with the actual CMS fast simulation, to which it has no relation). These are no longer required for any purpose, but still consume ~10% of Phase 2 reconstruction CPU time in 200PU.

This PR should be followed up by a reassessment of the usage of TrackTimeValueMapProducer, which provides the time smearing inputs (and, in principle, is no longer actually used anywhere).

PR validation:

Ran workflow 20434.0 successfully.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28446/12873

• This PR adds an extra 12KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoVertex/Configuration/python/RecoVertex_cff.py modified in PR(s): Add in beamspot constraints for timing hits and an improved track/MTD-hit selection BDT. #28279
  • File RecoVertex/Configuration/python/RecoVertex_phase2_timing_cff.py modified in PR(s): Add in beamspot constraints for timing hits and an improved track/MTD-hit selection BDT. #28279

[cmsbuild]

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

RecoVertex/Configuration

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3585/console Started: 2019/11/21 22:55

[kpedro88]

assign upgrade

[cmsbuild]

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

+1
Tested at: 496597e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f6a4b3/3585/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f6a4b3/3585/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 88 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2785613
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2785271
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[kpedro88]

+upgrade
Comparison changes just due to removed collections

[perrotta]

+1

• Collections produced by the removed modules aren't used anywhere in the Phase2 workflows
• Jenkins tests pass and the only differences come from the removal of those products in output

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@pmeridian @parbol @bendavid @lgray FYI this update will be integrated tonight, please comment in case

[fabiocos]

+1