New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase 2 tracker: template CPE #28448
Conversation
@cmantill, CMSSW_11_0_X branch is closed for direct updates. cms-bot is going to move this PR to master branch. |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28448/12875
|
A new Pull Request was created by @cmantill (Cristina Ana Mantilla Suarez) for master. It involves the following packages: CondFormats/SiPixelTransient @perrotta, @andrius-k, @kmaeshima, @schneiml, @tlampen, @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @jfernan2, @fioriNTU, @slava77, @ggovi, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
@cmantill |
@mmusich thanks for the clarification |
@cmantill , I made cpu timing measurements with and without this PR on top of the baseline (it was CMSSW_11_0_X_2019-11-27-2300) and I did not notice any significant increase in time at step3. I am happy of it, of course. But could you please tell me how did you make the timing measurements in #28448 (comment), which apparently reports about a sizeable processing time increase with this PR |
@perrotta I ran step3 with |
The overall job time could be affected by some normalization issue caused by other jobs running in parallel on the same machine. One should make sure that there are not concurrent jobs while running your step3. |
@perrotta Running again, and making sure other are no other concurrent jobs I actually see a slight decrease in time (might be random?) Here is the diff log. with And running
no PR
|
Thank you @cmantill : this confirma my finding that timing is not affected by this PR |
+1
|
@mmusich thanks for the confirmation, the specific objects modified in this PR do not seem to enter directly into the digitization (it is the SiPixelkTemplate2D object that enters for what I can see). @christopheralanwest @tocheng @ggovi could you please check the latest update and comment or sign it? |
right. The 2D template objects are needed for the charge re-weighting which we'll use to inject the radiation damage simulation, but this will be provided later on as the phase-2 digitizer needs to be adjusted first to consume it. This will be one milestone development for the next cycle. |
@ggovi the changes since your signature were merely technical could you pleas echeck and sign it again? In any case I will consider your previous signature as valid |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR integrates the template method for the pixel hit reconstruction in the Cluster Parameter Estimators (CPEs) for Phase 2. The templates have been produced for 5 different geometries in a "temporary" configuration that has been described in detail here [1]. The PR introduces the following changes:
@mmusich @tsusa @OzAmram @tvami
PR validation:
Tested with phase 2 workflows:
runTheMatrix.py --what upgrade -l 20007.0,20407.0,20807.0,21607.0,22007.0,22807.0,22834.0 -t 4 -j 8
.The template method for pixel hit residuals has been also tested running the reconstruction step for 100K events and results will be shown here [2]. Since the templates have been produced under "temporary" conditions, we do not expect a big change in the resolution results obtained with this method.
[1] https://indico.cern.ch/event/838960/contributions/3630543/attachments/1941870/3220114/CMS_phase2tem_Nov5.pdf
[2] https://indico.cern.ch/event/838961/
if this PR is a backport please specify the original PR:
NA