Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update severely outdated default values in Scouting producers #28481

Merged
merged 1 commit into from Nov 27, 2019

Conversation

jsalfeld
Copy link
Contributor

PR description:

I am updating default parameters in the scouting producers. While also being configured in the HLT menus, similar parameters have led to not store muons in muon scouting streams

PR validation:

I ran OnLine_HLT_GRun.py with the updated input to the Scouting packers, and saw that Muons Isolation, Muons in PFScouting and the btagger for PFJets is now correctly computed.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28481/12921

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jsalfeld (Jakob Salfeld-Nebgen) for master.

It involves the following packages:

HLTrigger/JetMET
HLTrigger/Muon

@Martin-Grunewald, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @Fedespring, @Martin-Grunewald, @calderona, @HuguesBrun, @jhgoh, @cericeci, @trocino, @folguera this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor

This is not automatically propagated to the HLT menus. You'd need to file a JIRA request for that!

@jsalfeld
Copy link
Contributor Author

@Martin-Grunewald yes this will come in addition.

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 26, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3649/console Started: 2019/11/26 17:30

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1d104/3649/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2787584
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2787242
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@Martin-Grunewald
Copy link
Contributor

type bug-fix

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit cdb8df3 into cms-sw:master Nov 27, 2019
desc.add<edm::InputTag>("EcalPFClusterIsoMap", edm::InputTag("hltMuonEcalMFPFClusterIsoForMuons"));
desc.add<edm::InputTag>("HcalPFClusterIsoMap", edm::InputTag("hltMuonHcalRegPFClusterIsoForMuons"));
desc.add<edm::InputTag>("TrackIsoMap", edm::InputTag("hltMuonTkRelIsolationCut0p07Map:combinedRelativeIsoDeposits"));
desc.add<edm::InputTag>("displacedvertexCollection", edm::InputTag("hltPixelVertices"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this make sense for the displacedvertexCollection (supposed to be the dimuon vertex) to use essentially the PV collection?
Since this is a default overwritten by the calo or PF variants, I guess it may not really matter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats right, I took for now the PF as default since here we had the problems. For the PF Muon Scouting path, the displaced vertex dimuon vertex collection is not produced (to be added...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants