New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update severely outdated default values in Scouting producers #28481
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28481/12921
|
A new Pull Request was created by @jsalfeld (Jakob Salfeld-Nebgen) for master. It involves the following packages: HLTrigger/JetMET @Martin-Grunewald, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
This is not automatically propagated to the HLT menus. You'd need to file a JIRA request for that! |
@Martin-Grunewald yes this will come in addition. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
type bug-fix |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
desc.add<edm::InputTag>("EcalPFClusterIsoMap", edm::InputTag("hltMuonEcalMFPFClusterIsoForMuons")); | ||
desc.add<edm::InputTag>("HcalPFClusterIsoMap", edm::InputTag("hltMuonHcalRegPFClusterIsoForMuons")); | ||
desc.add<edm::InputTag>("TrackIsoMap", edm::InputTag("hltMuonTkRelIsolationCut0p07Map:combinedRelativeIsoDeposits")); | ||
desc.add<edm::InputTag>("displacedvertexCollection", edm::InputTag("hltPixelVertices")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this make sense for the displacedvertexCollection (supposed to be the dimuon vertex) to use essentially the PV collection?
Since this is a default overwritten by the calo or PF variants, I guess it may not really matter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats right, I took for now the PF as default since here we had the problems. For the PF Muon Scouting path, the displaced vertex dimuon vertex collection is not produced (to be added...).
PR description:
I am updating default parameters in the scouting producers. While also being configured in the HLT menus, similar parameters have led to not store muons in muon scouting streams
PR validation:
I ran OnLine_HLT_GRun.py with the updated input to the Scouting packers, and saw that Muons Isolation, Muons in PFScouting and the btagger for PFJets is now correctly computed.