New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HCALDQM: Run3 era, add compatibility for new uTCA HO (10_6_X) #28485
HCALDQM: Run3 era, add compatibility for new uTCA HO (10_6_X) #28485
Conversation
A new Pull Request was created by @DryRun (David Yu) for CMSSW_10_6_X. It involves the following packages: DQM/HcalCommon @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Pull request #28485 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@DryRun why do we see changes in Hcal/DigiTask for the Offline Workflows too? Is it due to the modification in Constants.h ? |
Hi @jfernan2 - yes, indeed. HCAL has a couple more crates now, so after this update, plots with crate number on the axis will change. |
Thanks @DryRun I understand. However the plots are empty everywhere: |
@jfernan2 Right, I see that the plots are created for online/offline, but only filled for online... I'll fix that (besides the general HCAL DQM review) in a separate PR, to avoid holding this one up. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
PR description:
Some mandatory updates for HCAL DQM to run on the upgraded detector (HB and HO).
PR validation:
Ran
runTheMatrix.py -l limited -i all --ibeos
with no problems. Ran online DQM over run 328676.if this PR is a backport please specify the original PR:
#28484