Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCALDQM: Run3 era, add compatibility for new uTCA HO (10_6_X) #28485

Merged
merged 4 commits into from Jan 8, 2020

Conversation

DryRun
Copy link
Contributor

@DryRun DryRun commented Nov 27, 2019

PR description:

Some mandatory updates for HCAL DQM to run on the upgraded detector (HB and HO).

  • Move online DQM cfgs to use Run3 era.
  • More importantly, add crate-FED mapping for HO. Without this, the new HO electronics channels correspond to unknown crates, and HCAL DQM crashes.

PR validation:

Ran runTheMatrix.py -l limited -i all --ibeos with no problems. Ran online DQM over run 328676.

if this PR is a backport please specify the original PR:

#28484

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @DryRun (David Yu) for CMSSW_10_6_X.

It involves the following packages:

DQM/HcalCommon
DQM/Integration

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@threus, @batinkov this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #28485 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again.

@fioriNTU
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 27, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3658/console Started: 2019/11/27 08:41

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59f058/3658/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212324
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211989
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 19.25 KiB( 32 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 0.875 KiB Hcal/DigiTask
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@jfernan2
Copy link
Contributor

@DryRun why do we see changes in Hcal/DigiTask for the Offline Workflows too? Is it due to the modification in Constants.h ?

@DryRun
Copy link
Contributor Author

DryRun commented Nov 27, 2019

Hi @jfernan2 - yes, indeed. HCAL has a couple more crates now, so after this update, plots with crate number on the axis will change.

@jfernan2
Copy link
Contributor

Thanks @DryRun I understand. However the plots are empty everywhere:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_10_6_X_2019-11-26-2300+59f058/34346/dqm-histo-comparison-summary.html
Please, we need that review in HCAL DQM as we discussed at the last meeting on Friday

@DryRun
Copy link
Contributor Author

DryRun commented Nov 27, 2019

@jfernan2 Right, I see that the plots are created for online/offline, but only filled for online... I'll fix that (besides the general HCAL DQM review) in a separate PR, to avoid holding this one up.

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4157/console Started: 2020/01/07 16:24

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2020

+1
Tested at: 7b14f87
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59f058/4157/summary.html
CMSSW: CMSSW_10_6_X_2020-01-07-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59f058/4157/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212324
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211989
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 19.25 KiB( 32 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 0.875 KiB Hcal/DigiTask
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 33b8d82 into cms-sw:CMSSW_10_6_X Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants