Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure to run WriteStreamerFile before ReadStreamerFile #28491

Merged
merged 1 commit into from Nov 28, 2019
Merged

make sure to run WriteStreamerFile before ReadStreamerFile #28491

merged 1 commit into from Nov 28, 2019

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Nov 27, 2019

PR description:

Unit test ReadStreamerFile reads a data files which is generated by WriteStreamerFile . This PR makes sure that scram runs WriteStreamerFile before ReadStreamerFile

FYI @Dr15Jones

PR validation:

build and run locally ( for CentOs8)

[a]

===== Test "WriteStreamerFile" ====
Trying to Write a Streamer file
Trying to Write Out The Init message into Streamer File: teststreamfile.dat
Writing Event# : 2000 To Streamer file
Writing Event# : 2001 To Streamer file
Writing Event# : 2002 To Streamer file
Writing Event# : 2003 To Streamer file
Writing Event# : 2004 To Streamer file
Writing Event# : 2005 To Streamer file
Writing Event# : 2006 To Streamer file
Writing Event# : 2007 To Streamer file
Writing Event# : 2008 To Streamer file
Writing Event# : 2009 To Streamer file

---> test WriteStreamerFile succeeded
 
^^^^ End Test WriteStreamerFile ^^^^
Package IOPool/Streamer: Running test ReadStreamerFile
 
===== Test "ReadStreamerFile" ====
27-Nov-2019 16:05:03 CET  Initiating request to open file teststreamfile.dat
27-Nov-2019 16:05:03 CET  Successfully opened file teststreamfile.dat
Trying to Read The Init message from Streamer File: teststreamfile.dat
27-Nov-2019 16:05:03 CET  Closed file teststreamfile.dat
27-Nov-2019 16:05:03 CET  Initiating request to open file file:teststreamfile.dat
27-Nov-2019 16:05:03 CET  Successfully opened file file:teststreamfile.dat
Trying to Read The Init message from Streamer File: teststreamfile.dat
27-Nov-2019 16:05:03 CET  Closed file file:teststreamfile.dat
27-Nov-2019 16:05:03 CET  Initiating request to open file file:teststreamfile.dat
27-Nov-2019 16:05:03 CET  Successfully opened file file:teststreamfile.dat
File Boundary has just been crossed, a new file is read
A new INIT Message is available
Event from next file is also avialble
 TOTAL Events Read: 20
27-Nov-2019 16:05:03 CET  Closed file file:teststreamfile.dat
Exception caught:  An exception of category 'LogicalFileNameNotFound' occurred.
Exception Message:
StreamerInputFile::openStreamerFile()
Logical file name 'teststreamfile.dat' was not found in the file catalog.
If you wanted a local file, you forgot the 'file:' prefix
before the file name in your configuration file.


ReadStreamerFile TEST DONE


---> test ReadStreamerFile succeeded

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28491/12936

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 27, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3667/console Started: 2019/11/27 16:16

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

IOPool/Streamer

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dfb584/3667/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2793840
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2793498
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor Author

+core

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c20438a into cms-sw:master Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants