Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added EcalPFSeedingThresholds to plugins #28502

Merged
merged 1 commit into from Dec 4, 2019
Merged

Conversation

argiro
Copy link
Contributor

@argiro argiro commented Nov 28, 2019

PR description:

complements #28324, addition of a new record
The addition of the new record to plugins.cc was overlooked

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28502/12953

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @argiro for master.

It involves the following packages:

CondCore/EcalPlugins

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@argiro
Copy link
Contributor Author

argiro commented Nov 29, 2019

@ggovi, @cmsbuild can you please approve this trivial fix ? thanks

@smuzaffar smuzaffar modified the milestones: CMSSW_11_0_X, CMSSW_11_1_X Dec 2, 2019
@ggovi
Copy link
Contributor

ggovi commented Dec 4, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3784/console Started: 2019/12/04 10:04

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-edb446/3784/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2793840
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2793497
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Dec 4, 2019

looking at the code it should not break #28214

@fabiocos
Copy link
Contributor

fabiocos commented Dec 4, 2019

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants