Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix coordinates swap into SiStrip gains payload inspector #28515

Merged
merged 1 commit into from Dec 5, 2019

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Dec 2, 2019

PR description:

Trivial bug-fix. Coordinates in a scatter plot were inverted.

PR validation:

Unit test still run.

  • Original plot:
    image
  • Fixed plot:
    image

if this PR is a backport please specify the original PR:

NA

@mmusich
Copy link
Contributor Author

mmusich commented Dec 2, 2019

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28515/12980

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2019

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondCore/SiStripPlugins

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich, @VinInn this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@smuzaffar smuzaffar modified the milestones: CMSSW_11_0_X, CMSSW_11_1_X Dec 2, 2019
@fabiocos
Copy link
Contributor

fabiocos commented Dec 4, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3799/console Started: 2019/12/04 18:13

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b639f3/3799/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2793840
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2793497
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Dec 5, 2019

@ggovi please have a look, it looks a technical fix, I will integrate it into next IB

@fabiocos
Copy link
Contributor

fabiocos commented Dec 5, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented Dec 5, 2019

merge

@cmsbuild cmsbuild merged commit 4c8d339 into cms-sw:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants