New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable unit test for ppc64le due to lack of tfcompiler #28526
disable unit test for ppc64le due to lack of tfcompiler #28526
Conversation
please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28526/12997
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master. It involves the following packages: PhysicsTools/TensorFlow @perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
@smuzaffar @vlimant is tf v2.0 something to target now (we are still using 1.6)? Is v2.0 compatible with models made in the older versions? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
On Dec 5, 2019, at 4:20 AM, Slava Krutelyov <notifications@github.com<mailto:notifications@github.com>> wrote:
+1
for #28526<#28526> 7ebca8e<7ebca8e>
* code changes are in line with the PR description; the change is consistent with the update in the cmsdist made early this year in cms-sw/cmsdist@f73480e<cms-sw/cmsdist@f73480e>
* jenkins tests pass and comparisons with the baseline show no differences for the default ARCH tests
@smuzaffar<https://github.com/smuzaffar>
is the situation expected to improve in a more recent version of the tensorflow?
What is the status of updating to it, BTW?
I had understood that the c++ interface (which is done in an unsupported way) has still not been made to work in v2.0 (or versions in between)
@vlimant<https://github.com/vlimant> is tf v2.0 something to target now (we are still using 1.6)? Is v2.0 compatible with models made in the older versions?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#28526?email_source=notifications&email_token=ABGPFQ7NMSEAMEJBJFYXPRLQXBXRFA5CNFSM4JUVZFG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF7KZGI#issuecomment-561949849>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ4WBQNWOOIJTJAIOH3QXBXRFANCNFSM4JUVZFGQ>.
|
+1 |
PR description:
We do not have
tfcompiler
build forppc64le
this causes build errors inppc64le
IBshttps://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_ppc64le_gcc820/CMSSW_11_1_X_2019-12-02-2300/PhysicsTools/TensorFlow
This PR proposes to not build this unit test on ppc64le.