New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix loop bounds off-by-one errors in TrackerAlignment_PayloadInspector #28532
fix loop bounds off-by-one errors in TrackerAlignment_PayloadInspector #28532
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28532/13005
|
A new Pull Request was created by @dan131riley (Dan Riley) for master. It involves the following packages: CondCore/AlignmentPlugins @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@ggovi this looks a technical fix, please check, I will integrate it |
+1 |
merge |
PR description:
Adress sanitizer (ASAN) unit tests found two off-by-one errors in the TrackerAlignment_PayloadInspector. Both errors read one place past the end of the vectors being compared.
PR validation:
Reran unit tests in an ASAN build and verified that the heap-buffer-overflow errors were fixed.