Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix loop bounds off-by-one errors in TrackerAlignment_PayloadInspector #28532

Conversation

dan131riley
Copy link

PR description:

Adress sanitizer (ASAN) unit tests found two off-by-one errors in the TrackerAlignment_PayloadInspector. Both errors read one place past the end of the vectors being compared.

PR validation:

Reran unit tests in an ASAN build and verified that the heap-buffer-overflow errors were fixed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28532/13005

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2019

A new Pull Request was created by @dan131riley (Dan Riley) for master.

It involves the following packages:

CondCore/AlignmentPlugins

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3775/console Started: 2019/12/03 22:19

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30aec6/3775/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2793840
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2793498
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Dec 5, 2019

@ggovi this looks a technical fix, please check, I will integrate it

@fabiocos
Copy link
Contributor

fabiocos commented Dec 5, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented Dec 5, 2019

merge

@cmsbuild cmsbuild merged commit ccb1a30 into cms-sw:master Dec 5, 2019
@dan131riley dan131riley deleted the TrackerAlignment_PayloadInspector-ASAN-fix branch December 6, 2019 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants