Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LHEPtFilter plugin needed for MC generation [93X backport] #28543

Merged

Conversation

ajgilbert
Copy link
Contributor

PR description:

Backport of #28443, needed in 9_3_X for official production of 2017 MC using this filter.

Adds a new plugin in GeneratorInterface/GenFilters that applies a user specified pT (or pT range) cut to the p4 sum of a subset of LHE-level particles. This is needed specifically for the production of Wgamma samples binned in the photon pT, but may be useful more generally in the future.

PR validation:

All tests in runTheMatrix.py passed.

if this PR is a backport please specify the original PR:

Yes, #28443

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2019

A new Pull Request was created by @ajgilbert (Andrew Gilbert) for CMSSW_9_3_X.

It involves the following packages:

GeneratorInterface/GenFilters

@SiewYan, @efeyazgan, @mkirsano, @cmsbuild, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos, @kpedro88 you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

kpedro88 commented Dec 4, 2019

backport of #28443

@kpedro88
Copy link
Contributor

kpedro88 commented Dec 4, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3795/console Started: 2019/12/04 15:23

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1509d8/3795/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2624448
  • DQMHistoTests: Total failures: 226
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2624045
  • DQMHistoTests: Total skipped: 177
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -24 KiB( 24 files compared)
  • Checked 105 log files, 8 edm output root files, 25 DQM output files

@qliphy
Copy link
Contributor

qliphy commented Dec 6, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2019

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos, @kpedro88 (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Dec 6, 2019

+1

@cmsbuild cmsbuild merged commit df4b8e6 into cms-sw:CMSSW_9_3_X Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants