Remove FWCore/GuiBrowsers #28584

fabiocos · 2019-12-09T10:42:19Z

PR description:

Action based on the discussion #28436 and the (null) feedback received so far in https://hypernews.cern.ch/HyperNews/CMS/get/swDevelopment/3544.html
In any case the qt external tool is being removed from future architectures (gcc900, cc8), so in any case this package could be used only based on a local qt installation (in case resurrected or not removed).

cmsbuild · 2019-12-09T10:42:54Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-12-09T10:47:10Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28584/13080

This PR adds an extra 12KB to repository

cmsbuild · 2019-12-09T10:47:47Z

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

FWCore/GuiBrowsers

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @ahinzmann, @gkasieczka, @wddgit, @clelange this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

fabiocos · 2019-12-09T10:47:53Z

please test

cmsbuild · 2019-12-09T10:48:22Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3872/console Started: 2019/12/09 11:49

cmsbuild · 2019-12-09T11:46:11Z

-1

Tested at: ca1d33b

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e59cd5/3872/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals AddOn

Unit Tests:

I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

RelVals:

When I ran the RelVals I found an error in the following workflows:
136.7611 step2

runTheMatrix-results/136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM/step2_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM.log

136.8311 step2

runTheMatrix-results/136.8311_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017/step2_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017.log

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

136.731 step3

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

136.85 step3

runTheMatrix-results/136.85_RunEGamma2018A+RunEGamma2018A+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Offline_L1TEgDQM+HARVEST2018_L1TEgDQM/step3_RunEGamma2018A+RunEGamma2018A+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Offline_L1TEgDQM+HARVEST2018_L1TEgDQM.log

136.788 step3

runTheMatrix-results/136.788_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017/step3_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017.log

1325.7 step2

runTheMatrix-results/1325.7_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2/step2_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2.log

135.4 step3

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step3_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15.log

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

158.0 step3

runTheMatrix-results/158.0_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO/step3_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO.log

10042.0 step3

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017/step3_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017.log

10024.0 step3

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017.log

10824.0 step3

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25.log

11634.0 step3

runTheMatrix-results/11634.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021.log

12434.0 step3

runTheMatrix-results/12434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023_GenSimFull+DigiFull_2023+RecoFull_2023+HARVESTFull_2023+ALCAFull_2023/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023_GenSimFull+DigiFull_2023+RecoFull_2023+HARVESTFull_2023+ALCAFull_2023.log

10224.0 step3

runTheMatrix-results/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU+NanoFull_2017PU/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU+NanoFull_2017PU.log

20034.0 step3

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35.log

20434.0 step3

runTheMatrix-results/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41.log

23234.0 step3

runTheMatrix-results/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49.log

21234.0 step3

runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlobal_2026D44/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlobal_2026D44.log

250202.181 step4

runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step4_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log

AddOn:

I found errors in the following addon tests:

cmsRun /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-08-2300/src/PhysicsTools/PatAlgos/test/IntegrationTest_cfg.py : FAILED - time: date Mon Dec 9 12:29:10 2019-date Mon Dec 9 12:29:08 2019 s - exit: 23040

cmsbuild · 2019-12-09T11:46:14Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

fabiocos · 2019-12-09T14:27:44Z

there is a list of interesting python dependencies on this package in PhysicsToos/PatAlgos which i had missed. The PR needs obviously to be updated if we want to push further this move

cmsbuild · 2019-12-10T14:24:23Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e59cd5/3898/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2800084
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2799742
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

Dr15Jones · 2019-12-10T14:38:29Z

@makortel and myself strongly agree that ConfigToolBase.py should not be in FWCore. It is a piece of code only needed by the PAT based tools. Even the HI use is for HI support of PAT.

fabiocos · 2019-12-10T14:43:17Z

apparently everybody agrees on the "not in my backyard" principle...

slava77 · 2019-12-10T15:14:12Z

IIUC, all use cases are still in PhysicsTools/PatAlgos/python/tools or start from there. It can be moved there.

fabiocos · 2019-12-10T15:28:35Z

@slava77 this is where it sits now after the changes in the latest commit, if there is no more general use case it might be ok

Dr15Jones · 2019-12-10T18:10:55Z

+1

jfernan2 · 2019-12-11T12:25:26Z

+1

santocch · 2019-12-11T19:41:47Z

+1

perrotta · 2019-12-16T16:11:10Z

+1

Reco code only touched by the move of ConfigToolBase from FWCore.GuiBrowsers into PhysicsTools.PatAlgos.tools, which is a location apparently everybody agrees with
The removal of HiCoreTools and HiHelperTools can be quite likely safely done, but it can be postponed to a following PR
Jenkins tests pass

cmsbuild · 2019-12-16T16:11:43Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-12-16T17:08:16Z

+1

Remove FWCore/GuiBrowsers

ca1d33b

cmsbuild added this to the CMSSW_11_1_X milestone Dec 9, 2019

cmsbuild added code-checks-pending comparison-pending core-pending orp-pending pending-signatures tests-pending labels Dec 9, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 9, 2019

cmsbuild added tests-started and removed tests-pending labels Dec 9, 2019

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Dec 9, 2019

fabiocos added 3 commits December 9, 2019 15:48

Remove reference and script meant to use FWCore/GuiBrowsers

622247a

Move ConfigToolBase into Utilities and adjust references to it

44ebbe1

Fix FWCore/Utilities/test/BuildFile.xml for scram warning

dbff12b

cmsbuild removed code-checks-approved comparison-notrun tests-rejected labels Dec 9, 2019

cmsbuild added comparison-available and removed comparison-pending labels Dec 10, 2019

cmsbuild added core-approved and removed core-pending labels Dec 10, 2019

cmsbuild added dqm-approved and removed dqm-pending labels Dec 11, 2019

cmsbuild added analysis-approved and removed analysis-pending labels Dec 11, 2019

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Dec 16, 2019

cmsbuild added orp-approved and removed orp-pending labels Dec 16, 2019

cmsbuild merged commit 4546ca5 into cms-sw:master Dec 16, 2019

This was referenced Dec 16, 2019

Is FWCore/GuiBrowser really needed? #28436

Closed

Removal of HiCoreTools and HiHelperTools #28632

Closed

cmsbuild mentioned this pull request Dec 17, 2019

[Geant4] Code adjustment for new Geant4 version #28637

Merged

fabiocos deleted the fc-noguibrowsers branch December 18, 2019 13:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove FWCore/GuiBrowsers #28584

Remove FWCore/GuiBrowsers #28584

fabiocos commented Dec 9, 2019

cmsbuild commented Dec 9, 2019

cmsbuild commented Dec 9, 2019

cmsbuild commented Dec 9, 2019

fabiocos commented Dec 9, 2019

cmsbuild commented Dec 9, 2019 •

edited

cmsbuild commented Dec 9, 2019

cmsbuild commented Dec 9, 2019

fabiocos commented Dec 9, 2019

cmsbuild commented Dec 10, 2019

Dr15Jones commented Dec 10, 2019

fabiocos commented Dec 10, 2019

slava77 commented Dec 10, 2019

fabiocos commented Dec 10, 2019

Dr15Jones commented Dec 10, 2019

jfernan2 commented Dec 11, 2019

santocch commented Dec 11, 2019

perrotta commented Dec 16, 2019

cmsbuild commented Dec 16, 2019

fabiocos commented Dec 16, 2019

Remove FWCore/GuiBrowsers #28584

Remove FWCore/GuiBrowsers #28584

Conversation

fabiocos commented Dec 9, 2019

PR description:

cmsbuild commented Dec 9, 2019

cmsbuild commented Dec 9, 2019

cmsbuild commented Dec 9, 2019

fabiocos commented Dec 9, 2019

cmsbuild commented Dec 9, 2019 • edited

cmsbuild commented Dec 9, 2019

cmsbuild commented Dec 9, 2019

fabiocos commented Dec 9, 2019

cmsbuild commented Dec 10, 2019

Dr15Jones commented Dec 10, 2019

fabiocos commented Dec 10, 2019

slava77 commented Dec 10, 2019

fabiocos commented Dec 10, 2019

Dr15Jones commented Dec 10, 2019

jfernan2 commented Dec 11, 2019

santocch commented Dec 11, 2019

perrotta commented Dec 16, 2019

cmsbuild commented Dec 16, 2019

fabiocos commented Dec 16, 2019

cmsbuild commented Dec 9, 2019 •

edited