Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DQM] Bin by bin normalization off by default #28616

Merged

Conversation

andrius-k
Copy link

PR description:

Normalization is now off by default in the DQM GUI when exploring bin by bin tool results in an overlay view.

PR validation:

PR was validated locally.

@andrius-k
Copy link
Author

please test

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@jfernan2
Copy link
Contributor

This PR is fixing this issue: #28442 (comment)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28616/13140

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 12, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3953/console Started: 2019/12/12 17:50

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @andrius-k (Andrius) for master.

It involves the following packages:

DQMServices/FileIO

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aea5e1/3953/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2798405
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2798063
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@andrius-k
Copy link
Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@smuzaffar
Copy link
Contributor

@andrius-k , I am testing cms-sw/cmsdist#5537 and noticed that this test does not run under python3 (CMSSW_11_1_PY3_X IBs). Please see the errors here
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_1_PY3_X_2020-02-10-2300+1e2753/35036/dqmBinByBinLog.log

Can you please provide a fix for python3?

@andrius-k
Copy link
Author

@smuzaffar Thanks for spotting this. visDQMUpload is not compatible with python3 - I will fix this.

@andrius-k
Copy link
Author

Hi @smuzaffar,
I ported visDQMUpload to work also on python3: #28970
Regards,
Andrius

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants