Utilities/StaticAnalyzers: Add CMS_SA_ALLOW exceptions on Static Analyzer checks involving Decls.

[gartung]

Allows the user of cms threads safety macro CMS_SA_ALLOW in declarations that should be allowed to suppress the warning associated with the static analyzer check. This is done to reduce the volume of warnings in the static analyzer reports.

[gartung]

@Dr15Jones

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28630/13173

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28630/13173/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28630/13173/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28630/13174

• This PR adds an extra 24KB to repository

[Dr15Jones]

@gartung could you give an example, as a comment in this pull request, on what new declarations can be marked?

[cmsbuild]

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

Utilities/StaticAnalyzers

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[gartung]

CMS_SA_ALLOW can be used before these declarations

Stand alone checkers

• Before any non-const static local variable declaration
• Before any non-const static member declaration
• Before any mutable member declaration
• Before any extern C declaration

CatchAll checker:

• Before a function body declaration that uses catch(...)

Function checker:
Before a function or function template body declaration where

• a non-const static local variable is accessed or modified
• a COMMONBLOCK variable accessed or modified
• non-const global static variable is accessed or modified

In a CMS data class:

Before a const member function declaration where

• a non-const static local variable is accessed
• a non-const static member variable accessed
• a non-const global static variable accessed
• member data is modified
• returns or has return type pointer to a non-const member variable
• returns or has return type object of type const std::vector<> or const td::vector<>&

Before a mutable member declaration.

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4021/console Started: 2019/12/17 10:35

[cmsbuild]

+1
Tested at: e73679c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a98071/4021/summary.html
CMSSW: CMSSW_11_1_X_2019-12-16-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[gartung]

test with cms-sw/cmsdist#5445

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5445
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4086/console Started: 2019/12/21 16:43

[cmsbuild]

+1
Tested at: 1a2113b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6fefb9/4086/summary.html
CMSSW: CMSSW_11_1_X_2019-12-21-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6fefb9/4086/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2813777
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2813435
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[Dr15Jones]

@gartung what is the state of this? Were you able to get the annotation of try {} catch(...) to work?

[gartung]

Yes the putting CMS_SA_ALLOW in front of the try statement will suppress the warning about catch (...) I tested it on the try catch in FWCore/Services and it works.

[gartung]

Making vetos for the other checkers can be in another pull request.

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos, @silviodonato (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1