Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration of HLT menus to 11_0_0 Template (11_0_X) #28679

Merged
merged 2 commits into from Jan 8, 2020

Conversation

Martin-Grunewald
Copy link
Contributor

PR description:

Migration of HLT menus to 11_0_0 Template (11_0_X)
Based on CMSSW_11_0_0

PR validation:

TSG tests

if this PR is a backport please specify the original PR:

11_0 fork, not a backport!

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_11_0_X.

It involves the following packages:

HLTrigger/Configuration

@Martin-Grunewald, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos, @silviodonato you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 23, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4094/console Started: 2019/12/23 12:52

@cmsbuild
Copy link
Contributor

-1

Tested at: 90d3111

CMSSW: CMSSW_11_0_X_2019-12-23-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34f9b8/4094/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

  • AddOn:

I found errors in the following addon tests:

cmsRun /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-12-23-1100/src/HLTrigger/Configuration/test/OnLine_HLT_2018.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Mon Dec 23 13:49:49 2019-date Mon Dec 23 13:43:33 2019 s - exit: 18688
cmsDriver.py RelVal -s HLT:2018,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_2018 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_2018_MC.root --fileout file:RelVal_Raw_2018_MC_HLT_RECO.root : FAILED - time: date Mon Dec 23 13:49:49 2019-date Mon Dec 23 13:43:33 2019 s - exit: 18688
cmsRun /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-12-23-1100/src/HLTrigger/Configuration/test/OnLine_HLT_2018.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Mon Dec 23 13:48:47 2019-date Mon Dec 23 13:43:45 2019 s - exit: 18688
cmsDriver.py RelVal -s HLT:2018,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_2018 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_2018_DATA.root --fileout file:RelVal_Raw_2018_DATA_HLT_RECO.root : FAILED - time: date Mon Dec 23 13:48:47 2019-date Mon Dec 23 13:43:45 2019 s - exit: 18688

@cmsbuild
Copy link
Contributor

Comparison job queued.

@Martin-Grunewald
Copy link
Contributor Author

2018 menu needs migration as well!

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34f9b8/4094/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2793714
  • DQMHistoTests: Total failures: 192
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2793181
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.012 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 0.002 KiB HLT/GeneralHLTOffline
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@cmsbuild
Copy link
Contributor

Pull request #28679 was updated. @Martin-Grunewald, @cmsbuild, @fwyzard can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 23, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4095/console Started: 2019/12/23 15:37

@cmsbuild
Copy link
Contributor

+1
Tested at: 262dd08
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34f9b8/4095/summary.html
CMSSW: CMSSW_11_0_X_2019-12-23-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34f9b8/4095/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2793714
  • DQMHistoTests: Total failures: 192
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2793181
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.012 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 0.002 KiB HLT/GeneralHLTOffline
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@Martin-Grunewald
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos, @silviodonato (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ffae8f7 into cms-sw:CMSSW_11_0_X Jan 8, 2020
@Martin-Grunewald Martin-Grunewald deleted the HLTmigrationTo1100 branch October 27, 2021 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants