Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport of quark and gluons Py8EGun in CMSSW_10_2_X #28734

Merged
merged 1 commit into from Jan 14, 2020

Conversation

vberta
Copy link
Contributor

@vberta vberta commented Jan 13, 2020

PR description:

Added a feature to the Py8EGun: now the gun can use also quark or gluons. This feature was already present in the Py8PtGun, but not in the EGun.
This feature is required for the MC production for the training of DeeoCore Algorithm in forward region. see this jira ticked for details: [(https://its.cern.ch/jira/browse/PDMVRELVALS-65#add-comment)].

if this PR is a backport please specify the original PR:

This is the original PR on master. Because the modification is a single file, I did it by hand reimplementing the features (copy-paste of the modified line instead using rebase/cherry pick of the commit).
#28658

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vberta for CMSSW_10_2_X.

It involves the following packages:

GeneratorInterface/Pythia8Interface

@SiewYan, @efeyazgan, @mkirsano, @cmsbuild, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@qliphy
Copy link
Contributor

qliphy commented Jan 14, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 14, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4218/console Started: 2020/01/14 05:15

@cmsbuild
Copy link
Contributor

+1
Tested at: 47e3a7b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b87716/4218/summary.html
CMSSW: CMSSW_10_2_X_2020-01-13-2300
SCRAM_ARCH: slc6_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b87716/4218/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007491
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007298
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@qliphy
Copy link
Contributor

qliphy commented Jan 14, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

@vberta please update the title of this PR to something more clear.

@vberta vberta changed the title quarkEGun_CMSSW_10_2_5 backport of quark and gluons Py8EGun in CMSSW_10_2_X Jan 14, 2020
@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1aa4451 into cms-sw:CMSSW_10_2_X Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants