New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utilities/StaticAnalysers: Unregister unused getParamDumper checker #28744
Utilities/StaticAnalysers: Unregister unused getParamDumper checker #28744
Conversation
The code-checks are being triggered in jenkins. |
The tests are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28744/13376
|
A new Pull Request was created by @gartung (Patrick Gartung) for master. It involves the following packages: Utilities/StaticAnalyzers @makortel, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
…hich requires a call to evalCall with different parameters when registered.
bbfe319
to
0deef1b
Compare
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28744/13378
|
Pull request #28744 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again. |
test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Unused getParamDumper checker requires a change to evalCall parameters in llvm/clang 9 in order to be registered. The text file produced was never used for anything. Unregistering the checker rather than removing it because it still compiles. It can be fixed at a later time if there is interest.