Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilities/StaticAnalysers: Unregister unused getParamDumper checker #28744

Conversation

gartung
Copy link
Member

@gartung gartung commented Jan 15, 2020

Unused getParamDumper checker requires a change to evalCall parameters in llvm/clang 9 in order to be registered. The text file produced was never used for anything. Unregistering the checker rather than removing it because it still compiles. It can be fixed at a later time if there is interest.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 15, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5456
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4236/console Started: 2020/01/15 19:33

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28744/13376

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

Utilities/StaticAnalyzers

@makortel, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

…hich requires a call to evalCall with different parameters when registered.
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@gartung gartung changed the title Utilities/StaticAnalysers: remove unused getParamDumper checker Utilities/StaticAnalysers: Unregister unused getParamDumper checker Jan 15, 2020
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28744/13378

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #28744 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again.

@gartung
Copy link
Member Author

gartung commented Jan 15, 2020

test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 15, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4238/console Started: 2020/01/15 20:07

@cmsbuild
Copy link
Contributor

+1
Tested at: 0deef1b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-188aea/4238/summary.html
CMSSW: CMSSW_11_1_X_2020-01-15-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-188aea/4238/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2711715
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2711368
  • DQMHistoTests: Total skipped: 346
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@makortel
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 89ba25b into cms-sw:master Jan 17, 2020
@gartung gartung deleted the gartung-utilities-staticanalyzers-remove-getParamDumper branch March 16, 2020 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants