GEM DQM updates - full GE1/1

[quark2]

PR description:

This PR updates and extends the part of onlineDQM for GEM. The details are following:

• The existing parts are fixed to match the VFAT version which is used in CMSSW currently
• Summary plot is added
• Histograms which displays the status of devices (AMCs, GEBs, VFATs) by time are added

Please see this to check more details, especially the visualization with DQM GUI (there is also an update for GEM part for onlineDQM GUI, which will be PRed soon)

PR validation:

Test are done and one can check again by runTheMatrix workflows

@jshlee @watson-ij

[cmsbuild]

The code-checks are being triggered in jenkins.

[boudoul]

Thanks for the PR.
@andrius-k, @kmaeshima, @schneiml, @jfernan2, @fioriNTU , assuming the PR review will converge, could please put this PR on the DQM plan for the next MWGR ? Thanks

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28769/13424

• This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28769/13424/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28769/13424/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[schneiml]

@boudoul next MWGR as in the one started today? We'd need a backport to 10_6 first for that, I just tried merging this one but it seems to be based on a later release.

[boudoul]

Hi @schneiml , obviously not the one started today , the PR should go first in a careful review and then for a backport (likley 11_0) , not to mention that there is no GEM in the current MWGR ...

[schneiml]

@boudoul ok, we got a bit surprised there exactly because GEM is not really doing anything... For next MWGR makes more sense.

[jfernan2]

Hi @quark2, I can't seem to find you in DQM contacts list. Could you please briefly introduce yourself?

[jshlee]

@jfernan2 - @quark2 is Byeonghak Ko, he is listed as a GEM Validation DQM Developer. We need to update that page with Byeonghak as the Online DQM Developer too.

Jason.

[jfernan2]

Thank you @jshlee
He was my guess, but I could not figure out since he has no name in Github

[jfernan2]

@quark2 there are code format patchs to apply to this PR

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28769/13451

• This PR adds an extra 40KB to repository

[cmsbuild]

A new Pull Request was created by @quark2 for master.

It involves the following packages:

DQM/GEM

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[quark2]

Wait, I found that after scram build code-format it cannot be compiled well. My bad... I'll fix it asap.

[cmsbuild]

+1
Tested at: 867e219
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ae5dd/4534/summary.html
CMSSW: CMSSW_11_1_X_2020-02-06-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ae5dd/4534/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2698043
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2697696
• DQMHistoTests: Total skipped: 346
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[jfernan2]

hold
Testing it in Online DQM playback

[cmsbuild]

Pull request has been put on hold by @jfernan2
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[jfernan2]

unhold
Tested succesfully in DQM Online playback

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1