[HLTrigger/JSONMonitoring] updated sanity check in L1TriggerJSONMonitoring

[missirol]

PR description:

This PR improves one sanity check done in the plugin L1TriggerJSONMonitoring, requiring that the GlobalAlgBlk object associated to BX=0 be not empty, in order to avoid a crash here.

This kind of crash occurred a few times during the last MWGR (see for example this elog); it was caused by the fact that the L1 uGT FED had not been included in the run.

If accepted, this should probably be backported to earlier releases that might be used in future global-runs.

Thanks to @fwyzard for suggesting the fix.

PR validation:

Validated with internal HLT tests (rerunning the HLT menu on the relevant error streams).

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28797/13490

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

HLTrigger/JSONMonitoring

@cmsbuild, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[fwyzard]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4365/console Started: 2020/01/27 15:01

[fwyzard]

@missirol could you prepare a backport to CMSSW_11_0_X ?

[fwyzard]

type bugfix

[cmsbuild]

+1
Tested at: ea13404
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8eeed5/4365/summary.html
CMSSW: CMSSW_11_1_X_2020-01-27-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8eeed5/4365/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2697090
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2696743
• DQMHistoTests: Total skipped: 346
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1