Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phase-2 GT to D49 geometry #28811

Merged
merged 1 commit into from Jan 29, 2020
Merged

Conversation

tocheng
Copy link
Contributor

@tocheng tocheng commented Jan 28, 2020

PR description:

PR description:

The PR is to update phase-2 GT in autoCond which contains D49 (T15 in autoCondPhase2 ) geometry as in PR #27517

PR validation:

A technical test was performed: runTheMatrix.py -l limited -i all --ibeos

if this PR is a backport please specify the original PR:

Backport of PR #28794

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tocheng (Tongguang) for CMSSW_11_0_X.

It involves the following packages:

Configuration/AlCa

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Jan 28, 2020

thanks @tocheng . I think there is a typo in the title, it is either T15 or D49. Thanks

@tocheng tocheng changed the title Update phase-2 GT to D15 geometry Update phase-2 GT to D49 geometry Jan 28, 2020
@tocheng
Copy link
Contributor Author

tocheng commented Jan 28, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 28, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4384/console Started: 2020/01/28 15:18

@silviodonato
Copy link
Contributor

@tocheng could you tell us why you need to backport this GT update to 11_0_X? thanks

@tocheng
Copy link
Contributor Author

tocheng commented Jan 28, 2020

@silviodonato
The default geometry scenario now is D49 or T15.
But the phase-2 GT in autoCond is not updated to D49 or T15. Symbolic linked GT is used as introduced in PR #27517, which is not a good candidate for real production. (Symbolic linked GT is expected to be used when the default geometry in under dev.)

So the phase-2 GT needs to be updated in 11_0 and 11_1 for phase-2 studies.

@cmsbuild
Copy link
Contributor

+1
Tested at: 9883fd5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d4d2e2/4384/summary.html
CMSSW: CMSSW_11_0_X_2020-01-28-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d4d2e2/4384/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2793840
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2793497
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@tocheng
Copy link
Contributor Author

tocheng commented Jan 28, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b51c000 into cms-sw:CMSSW_11_0_X Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants