Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-sim53 Make run3 scenario to work in dd4hep scenario #28870

Merged
merged 1 commit into from Feb 5, 2020

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Feb 5, 2020

PR description:

Set eval = true in 3 constant section to enable the scenario to work in dd4hep scenario

PR validation:

Tested with configuration in Geometry/CMSCommonData/test/python. Affects only dd4hep part

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2020

The code-checks are being triggered in jenkins.

@bsunanda
Copy link
Contributor Author

bsunanda commented Feb 5, 2020

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28870/13635

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4506/console Started: 2020/02/05 09:38

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2020

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/ForwardCommonData
Geometry/MuonCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@ptcox this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2020

+1
Tested at: 8cd6f87
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a8ab9/4506/summary.html
CMSSW: CMSSW_11_1_X_2020-02-04-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a8ab9/4506/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2698043
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2697696
  • DQMHistoTests: Total skipped: 346
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@cvuosalo
Copy link
Contributor

cvuosalo commented Feb 5, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fed6c76 into cms-sw:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants