Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running code-format for generators #28883

Merged
merged 1 commit into from Feb 8, 2020
Merged

Conversation

cmsbuild
Copy link
Contributor

@cmsbuild cmsbuild commented Feb 7, 2020

Applying code-format for CMSSW category generators.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/451//console

cms-bot has successfully run the following:

  • scram build code-checks-all
  • scram build code-format-all
  • scram build

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Feb 7, 2020

please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Feb 7, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Feb 7, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28883/13661

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Feb 7, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4540/console Started: 2020/02/07 15:15

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Feb 7, 2020

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

SimDataFormats/GeneratorProducts

@SiewYan, @efeyazgan, @mkirsano, @cmsbuild, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@apsallid, @rovere this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Feb 7, 2020

+1
Tested at: 843954b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d9e733/4540/summary.html
CMSSW: CMSSW_11_1_X_2020-02-07-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Feb 7, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Feb 7, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d9e733/4540/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2698043
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2697696
  • DQMHistoTests: Total skipped: 346
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@silviodonato
Copy link
Contributor

merge
harmless technical fix

@cmsbuild cmsbuild merged commit 430b56f into master Feb 8, 2020
@smuzaffar smuzaffar deleted the code-format-generators-c8ae24 branch February 13, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants