Running code-format for core

[cmsbuild]

Applying code-format for CMSSW category core.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/448//console

cms-bot has successfully run the following:

• scram build code-checks-all
• scram build code-format-all
• scram build

[cmsbuild]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28891/13669

• This PR adds an extra 8KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4549/console Started: 2020/02/07 15:20

[cmsbuild]

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

DataFormats/Common
Utilities/XrdAdaptor

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @rovere, @wddgit this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

Were these files missed before, or did we get an update in clang-format?

[smuzaffar]

I think it is bit of both. Clang format/tidy were not run for those packages for which there were already open PRs and we also have new llvm ( 9.0.1) now in 11.1.X.

[wddgit]

At least for these 3 files, the immediately preceding commit in the history is the result of running clang format, when I did it back in May. So something must have changed in clang-format or the way we are running it.

[smuzaffar]

yes, looks like side effect of new llvm version 9.0.1. Last time when we run clang-format was with llvm 7.

[cmsbuild]

+1
Tested at: 0ba31ec
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-225fc2/4549/summary.html
CMSSW: CMSSW_11_1_X_2020-02-07-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-225fc2/4549/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2698043
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2697696
• DQMHistoTests: Total skipped: 346
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1