Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running code-format for visualization #28892

Merged
merged 1 commit into from Feb 8, 2020

Conversation

cmsbuild
Copy link
Contributor

@cmsbuild cmsbuild commented Feb 7, 2020

Applying code-format for CMSSW category visualization.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/458//console

cms-bot has successfully run the following:

  • scram build code-checks-all
  • scram build code-format-all
  • scram build

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Feb 7, 2020

please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Feb 7, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Feb 7, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28892/13670

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Feb 7, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4548/console Started: 2020/02/07 15:19

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Feb 7, 2020

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

Fireworks/Core
Fireworks/FWInterface

@makortel, @cmsbuild, @Dr15Jones, @alja can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Feb 7, 2020

+1
Tested at: ea90f99
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc6151/4548/summary.html
CMSSW: CMSSW_11_1_X_2020-02-07-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Feb 7, 2020

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

@silviodonato
Copy link
Contributor

merge
harmless fix

@cmsbuild cmsbuild merged commit 815fa3f into master Feb 8, 2020
@smuzaffar smuzaffar deleted the code-format-visualization-b01007 branch February 13, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants