ConcurrentHadronizerFilter #28913
ConcurrentHadronizerFilter #28913
Conversation
This global module replicates the Hadronizer for each stream in order to run them concurrently. This only works for thread-friendly hadronizers, decayers and filters.
This is meant to give access to thread-friendly decayers. At the moment non such exist so if used the object will throw an exception.
This makes use of the ConcurrentHadronizerFilter.
Use identical clones of the random engine in order to setup the hadronizer and decayer on each LuminosityBlock boundary.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28913/13703
|
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: GeneratorInterface/Core @SiewYan, @efeyazgan, @mkirsano, @cmsbuild, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: d49909b CMSSW: CMSSW_11_1_X_2020-02-10-1100 I found follow errors while testing this PR Failed tests: ClangBuild
I found compilation error while trying to compile with clang. Command used: ^
/cvmfs/cms-ib.cern.ch/nweek-02615/slc7_amd64_gcc820/external/pythia8/243/include/Pythia8/SpaceShower.h:146:18: note: hidden overloaded virtual function 'Pythia8::SpaceShower::getSplittingProb' declared here: different number of parameters (5 vs 7)
virtual double getSplittingProb( const Event& , int , int , int , string )
^
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-10-1100/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:61:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-10-1100/src/GeneratorInterface/Core/interface/ConcurrentHadronizerFilter.h:139:20: error: 'callWhenNewProductsRegistered' following the 'template' keyword does not refer to a template
this->template callWhenNewProductsRegistered([ptrThis](BranchDescription const& iBD) {
^
/cvmfs/cms-ib.cern.ch/nweek-02615/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../include/c++/8.3.1/bits/unique_ptr.h:831:34: note: in instantiation of member function 'edm::ConcurrentHadronizerFilter::ConcurrentHadronizerFilter' requested here
{ return unique_ptr<_Tp>(new _Tp(std::forward<_Args>(__args)...)); }
^
|
|
Comparison not run due to Build errors/Fireworks only changes/No short matrix requested (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
The test used the following gen_cff.py import FWCore.ParameterSet.Config as cms
externalLHEProducer = cms.EDProducer("ExternalLHEProducer",
args = cms.vstring('/cvmfs/cms.cern.ch/phys_generator/gridpacks/2017/13TeV/powheg/V2/TT_hvq/patched/TT_hdamp_NNPDF31_NNLO_inclusive_patched_reducedPDFWeights.tgz'),
nEvents = cms.untracked.uint32(5000),
numberOfParameters = cms.uint32(1),
outputFile = cms.string('cmsgrid_final.lhe'),
scriptName = cms.FileInPath('GeneratorInterface/LHEInterface/data/run_generic_tarball_cvmfs.sh')
)
#Link to datacards:
#https://github.com/cms-sw/genproductions/blob/master/bin/Powheg/production/2017/13TeV/TT_hvq/TT_hdamp_NNPDF31_NNLO_inclusive.input
import FWCore.ParameterSet.Config as cms
from Configuration.Generator.Pythia8CommonSettings_cfi import *
from Configuration.Generator.MCTunes2017.PythiaCP5Settings_cfi import *
from Configuration.Generator.Pythia8PowhegEmissionVetoSettings_cfi import *
from Configuration.Generator.PSweightsPythia.PythiaPSweightsSettings_cfi import *
#generator = cms.EDFilter("Pythia8HadronizerFilter",
generator = cms.EDFilter("Pythia8ConcurrentHadronizerFilter",
maxEventsToPrint = cms.untracked.int32(1),
pythiaPylistVerbosity = cms.untracked.int32(1),
filterEfficiency = cms.untracked.double(1.0),
pythiaHepMCVerbosity = cms.untracked.bool(False),
comEnergy = cms.double(13000.),
PythiaParameters = cms.PSet(
pythia8CommonSettingsBlock,
pythia8CP5SettingsBlock,
pythia8PowhegEmissionVetoSettingsBlock,
pythia8PSweightsSettingsBlock,
processParameters = cms.vstring(
'POWHEG:nFinal = 2', ## Number of final state particles
## (BEFORE THE DECAYS) in the LHE
## other than emitted extra parton
'TimeShower:mMaxGamma = 1.0',#cutting off lepton-pair production
##in the electromagnetic shower
##to not overlap with ttZ/gamma* samples
'6:m0 = 172.5', # top mass'
),
parameterSets = cms.vstring('pythia8CommonSettings',
'pythia8CP5Settings',
'pythia8PowhegEmissionVetoSettings',
'pythia8PSweightsSettings',
'processParameters'
)
)
)
genParticlesForFilter = cms.EDProducer("GenParticleProducer",
abortOnUnknownPDGCode = cms.untracked.bool(False),
saveBarCodes = cms.untracked.bool(True),
src = cms.InputTag("generator", "unsmeared")
)
genParticlesForjetsForFilter = cms.EDProducer("InputGenJetsParticleSelector",
excludeFromResonancePids = cms.vuint32(12, 13, 14, 16),
excludeResonances = cms.bool(False),
ignoreParticleIDs = cms.vuint32(1000022, 1000012, 1000014, 1000016, 2000012,
2000014, 2000016, 1000039, 5100039, 4000012,
4000014, 4000016, 9900012, 9900014, 9900016,
39),
partonicFinalState = cms.bool(False),
src = cms.InputTag("genParticlesForFilter"),
tausAsJets = cms.bool(False)
)
ak8GenJetsForFilter = cms.EDProducer("FastjetJetProducer",
Active_Area_Repeats = cms.int32(5),
GhostArea = cms.double(0.01),
Ghost_EtaMax = cms.double(6.0),
Rho_EtaMax = cms.double(4.5),
doAreaFastjet = cms.bool(False),
doPUOffsetCorr = cms.bool(False),
doPVCorrection = cms.bool(False),
doRhoFastjet = cms.bool(False),
inputEMin = cms.double(0.0),
inputEtMin = cms.double(0.0),
jetAlgorithm = cms.string('AntiKt'),
jetPtMin = cms.double(3.0),
jetType = cms.string('GenJet'),
maxBadEcalCells = cms.uint32(9999999),
maxBadHcalCells = cms.uint32(9999999),
maxProblematicEcalCells = cms.uint32(9999999),
maxProblematicHcalCells = cms.uint32(9999999),
maxRecoveredEcalCells = cms.uint32(9999999),
maxRecoveredHcalCells = cms.uint32(9999999),
minSeed = cms.uint32(14327),
nSigmaPU = cms.double(1.0),
rParam = cms.double(0.8),
radiusPU = cms.double(0.5),
src = cms.InputTag("genParticlesForjetsForFilter"),
srcPVs = cms.InputTag(""),
useDeterministicSeed = cms.bool(True)
)
genHTFilter = cms.EDFilter("GenHTFilter",
genHTcut = cms.double(649.0),
jetEtaCut = cms.double(1000.0),
jetPtCut = cms.double(650.0),
src = cms.InputTag("ak8GenJetsForFilter")
)
LHEJetFilter = cms.EDFilter("LHEJetFilter",
jetPtMin = cms.double(350.0),
jetR = cms.double(0.8),
src = cms.InputTag("externalLHEProducer")
)
ProductionFilterSequence = cms.Sequence(LHEJetFilter*generator*genParticlesForFilter*genParticlesForjetsForFilter*ak8GenJetsForFilter*genHTFilter)test_cfg.py import FWCore.ParameterSet.Config as cms
process = cms.Process("GEN")
process.load("gen_cff")
process.load('IOMC.RandomEngine.IOMC_cff')
process.load('SimGeneral.HepPDTESSource.pythiapdt_cfi')
process.source = cms.Source("EmptySource")
process.maxEvents.input = 5000
process.options.wantSummary = True
process.options.numberOfThreads = 4
process.p = cms.Path(process.ProductionFilterSequence, cms.Task(process.externalLHEProducer)) |
|
It would be possible to allow our present Decayers to work with this class. I can see two ways to do it
Of course the absolute best would be to have access to thread-friendly decayers. |
|
@makortel FYI |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
We need generators' review @alberto-sanchez @agrohsje @efeyazgan @mkirsano @qliphy @SiewYan |
|
+1 |
cmsbuild
added
fully-signed
generators-approved
and removed
generators-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
I am willing to if that is seen as useful. The question I have is which configurations of Pythia8HadronizerFilter are actually used for production?
That would be fine as well. |
|
+1 |
|
Hi @Dr15Jones , BPH has some low filter efficiency requests that would be great if any gain in time/evt would be achieved. I share one cfg of interest. Currently, this request is producing ~35 events/lumisection in a 8hr condor job. The cfg uses Pythia8 as initialize but then evtGen (not Multi-Process capable) takes over to decay some particular particles. Other thing to notice is that we do not use the Pythia8HadronizerFilter but rather the Pythia8GeneratorFilter. Would you think that we could have some gain in here as well!? Many Thanks in advance, [1] |
|
The problem is EvtGen is not thread safe (as you pointed out) and therefore not ameanable to the code I orginally wrote. To really handle this case would be to write the code I had originally thought would be necessary which was using FWCore/SharedMemory to run all the generator code in a different process. Doing such would probably be about 2-4 weeks of work by me. |
|
@jordan-martins wrote
So I tried out the code in pull request #29445 using the configuration to which you pointed. My first observation is that configuration did not seem all that slow, it could do 2.98472 ev/s using 4 threads (although its CPU efficiency was very low). Using #29445 and 4 threads I got a 2.3x speed up (6.93303 ev/s) and very good CPU efficiency (based on results of watching |
PR description:
Created the ConcurrentHadronizerFilter. This templated class is similar to HadronizerFilter except it is thread-safe and can run the Hadronizer concurrently for different events.
The only hadronizer that has been instantiated is Pythia8 using a dummy decayer class, ConcurrentExternalDecayDriver.
PR validation:
The code was tested using a production workflow snippet where the Pythia8Hadronizer was replaced with the ConcurrentPythia8Hadronizer. In the snippet, no external decayer was begin specified.