MTD simulation and local reconstruction: code cleaning #28915
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28915/13708
|
|
A new Pull Request was created by @casarsa (Massimo Casarsa) for master. It involves the following packages: RecoLocalFastTime/Configuration @perrotta, @civanch, @kpedro88, @cmsbuild, @mdhildreth, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@casarsa there is no change in name of persistent collections as far as I can see, am I correct? |
|
Any comment from simulation @civanch @mdhildreth ? |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
please test workflow 23434.1001 |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
The tests are being triggered in jenkins.
|
|
+1 |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
PR description:
The obsolete and unused code has been removed from the SimFastTiming and RecoLocalFastTime packages, i.e. the code relative to the BTL design with scintillator tiles and the simple FTL device.
PR validation:
The purged code has been tested with the WF 23207.0 in CMSSW_11_1_X_2020-02-09-2300. The results of MTD simulation and local reconstruction are unaffected.