Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for HCAL online TPG LUT and Trigger keys #28930

Merged
merged 9 commits into from Feb 18, 2020

Conversation

ak427
Copy link

@ak427 ak427 commented Feb 12, 2020

PR description:

The PR includes updates for online HCAL LUT and trigger key generation. It should not affect any offline processing. Main changes include:

  • TriggerKey is now generated together with LUTs (as opposed to by a separate online tool)
  • adding typinfo element to both LUT and TriggerKey content to support new online xmldb format.
  • add input information for LUT generation to TriggerKey content which will be used by O2O for automatic synchronization of online LUTs and corresponding offline conditions updates
  • plus some minor fixes and improvements (input parameters are defined in input card, fix/update for crate to subdet id function etc. )

PR validation:

The code has been used to generate past and upcoming online LUTs and trigger keys.
The PR should not affect any offline workflow.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28930/13732

  • This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28930/13733

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ak427 for master.

It involves the following packages:

CalibCalorimetry/HcalTPGAlgos
CaloOnlineTools/HcalOnlineDb

@benkrikler, @christopheralanwest, @tocheng, @cmsbuild, @rekovic, @franzoni, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 12, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4619/console Started: 2020/02/12 14:43

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 13, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4646/console Started: 2020/02/13 14:26

@cmsbuild
Copy link
Contributor

Pull request #28930 was updated. @benkrikler, @christopheralanwest, @tocheng, @cmsbuild, @rekovic, @franzoni, @tlampen, @ggovi, @pohsun can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1
Tested at: a52fafd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-886622/4646/summary.html
CMSSW: CMSSW_11_1_X_2020-02-13-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-886622/4646/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2694005
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2693658
  • DQMHistoTests: Total skipped: 346
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@rekovic
Copy link
Contributor

rekovic commented Feb 17, 2020

+1

@christopheralanwest
Copy link
Contributor

+1

@ggovi
Copy link
Contributor

ggovi commented Feb 18, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e94878a into cms-sw:master Feb 18, 2020
@akhukhun akhukhun deleted the xmldbformat branch March 31, 2021 11:39
@akhukhun akhukhun restored the xmldbformat branch March 31, 2021 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants