Move contents of beginJob() to endJob() in APVValidationPlots #28942
Conversation
This move avoids storing TH1* pointers from MonitorElements as member variables (even though that should not cause any problems because no work is done during the event loop). Anyway, now it is crystal clear that this module accesses DQMStore only in endJob(), and does not need anything from elsewhere in CMSSW.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28942/13750
|
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: DQMOffline/CalibTracker @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
I also wonder if this code is really used anywhere. |
|
The tests are being triggered in jenkins. |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Following the discussion in #28920, this PR removes the
TH1*pointer member variables by moving the contents ofbeginJob()toendJob(). Now it is crystal clear that this module accesses DQMStore only inendJob(), and does not need anything elsewhere in CMSSW.PR validation:
Code compiles. I tried to run the two configuration files in
DQMOffline/CalibTracker/testthat useAPVValidationPlotsmodule, but they are nonfunctional for other reasons.