Fix #28803 (GenParticles2HepMC with exotic LHE) 10_6_X

[mseidel42]

PR description:

Fixes crash in GenParticles2HepMCConverter (#28803) by adding fake beam particles for exotic LHE files with only one beam-particle candidate. This was used for NeutrinoGun samples (no beam particles) before.

PR validation:

• Processed NanoAod from problematic events (in 10_2_X: Fix #28803 (GenParticles2HepMC with exotic LHE) #28856)
• Processed MiniAod events to produce Rivet histograms

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #28876

[cmsbuild]

A new Pull Request was created by @intrepid42 (Markus Seidel) for CMSSW_10_6_X.

It involves the following packages:

GeneratorInterface/RivetInterface

@SiewYan, @efeyazgan, @mkirsano, @cmsbuild, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[qliphy]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4648/console Started: 2020/02/13 16:18

[cmsbuild]

+1
Tested at: 88b342c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0adf0e/4648/summary.html
CMSSW: CMSSW_10_6_X_2020-02-13-1100
SCRAM_ARCH: slc7_amd64_gcc700

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0adf0e/4648/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3212324
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211988
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[qliphy]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

@intrepid42
I noticed you are chaning GeneratorInterface/RivetInterface/test/runRivetAnalyzerMiniAOD_cfg.py
in this PR #28958 (10_6_X) and #28856 (10_2_X), while the file is not changed in #28876 (11_1_X).
Could you comment on this difference?

[mseidel42]

Hi Silvio, the test in 11_1_x runs on RunIIAutumn18MiniAOD already.

cmssw/GeneratorInterface/RivetInterface/test/runRivetAnalyzerMiniAOD_cfg.py

Line 21 in 891e797

'/store/mc/RunIIAutumn18MiniAOD/TT_noSC_TuneCP5_13TeV-powheg-pythia8/MINIAODSIM/102X_upgrade2018_realistic_v15-v1/60000/26D8AE17-B828-C948-A961-A785C6CB71CE.root',

For the older releases, I just updated the RelVal to a file that is compatible and still accessible.

[silviodonato]

+1
ok, thanks for the check