New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slightly refactor PF endcap cluster calibration #28960
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28960/13786
|
A new Pull Request was created by @guitargeek (Jonas Rembser) for master. It involves the following packages: RecoEcal/EgammaClusterAlgos @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
double ps2_energy_sum = 0.; | ||
double ePS1 = 0.; | ||
double ePS2 = 0.; | ||
int condP1 = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe if you make these two some "bool" variable, everything gets more intuitive
//getStatusCode() == 0 => active channel | ||
// apply correction if all recHits are dead | ||
if (channelStatus.getMap().find(strip1)->getStatusCode() == 0) | ||
condP1 = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can break here
ESDetId strip2 = recH.recHitRef()->detId(); | ||
if (strip2 != ESDetId(0)) { | ||
if (channelStatus.getMap().find(strip2)->getStatusCode() == 0) | ||
condP2 = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can break here
Hi @perrotta, now it's ready to be tested again. I only kept the change with using the other overloaded version of the |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
[I'm not sure if this is the PR with the problem, but the error messages appear to point to this] @smuzaffar @mrodozov
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_ppc64le_gcc820/CMSSW_11_1_X_2020-03-08-2300/pyRelValMatrixLogs/run/140.52_RunHI2010+RunHI2010+RECOHID10+RECOHIR10D11+HARVESTDHI/step2_RunHI2010+RunHI2010+RECOHID10+RECOHIR10D11+HARVESTDHI.log |
ping
|
@slava77 send me your ssh public key |
I managed to get to the error in PerformancePayload. |
PR description:
In the PFEgammaAlgo, there is still this comment about code "stolen" from the PFECALSuperClusterAlgo:
https://github.com/cms-sw/cmssw/blob/master/RecoParticleFlow/PFProducer/src/PFEGammaAlgo.cc#L1774
I was thinking of ways to avoid this duplication, but it's not quite trivial because the code diverged a bit. However, a bit part of the duplicate code serves to compute cluster energy corrections, so I could move this into the PFEnergyCalibration class which is used by both algos. I think this is a good step to avoid this code duplication, but I don't want to go further for now to not risk accidentally changing the logic. What do you think?
PR validation:
CMSSW compiles and matrix tests pass.
if this PR is a backport please specify the original PR and why you need to backport that PR:
No backport intended.