Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct ECAL timing calibration for Run2018D [11_0_X] #28982

Conversation

christopheralanwest
Copy link
Contributor

PR description:

This PR provides GTs with the correct ECAL timing calibration for Run2018D and is a backport of PR #28981; please see the description of that PR for further details. The GT diffs are as follows:

https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_v9/110X_dataRun2_v11
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_dataRun2_relval_v9/110X_dataRun2_relval_v11

The AlCaReco update contained in the 110X_dataRun2_v10 and 110X_dataRun2_relval_v10 GTs is not included, as the corresponding code changes are not merged in 11_0_X, only 11_1_X.

PR validation:

In addition to the physics validation (see PR #28981 for details), a technical test was performed: runTheMatrix.py -l limited --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is a backport of PR #28981.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @christopheralanwest for CMSSW_11_0_X.

It involves the following packages:

Configuration/AlCa

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 18, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4717/console Started: 2020/02/18 07:38

@christopheralanwest christopheralanwest changed the title Correct ECAL timing calibration for Run2018D Correct ECAL timing calibration for Run2018D [11_0_X] Feb 18, 2020
@cmsbuild
Copy link
Contributor

+1
Tested at: 97b8881
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-75f843/4717/summary.html
CMSSW: CMSSW_11_0_X_2020-02-17-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-75f843/4717/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2793840
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2793498
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@christopheralanwest
Copy link
Contributor Author

+1

  • No changes are observed or expected in any workflow, since there are no 2018D workflows in the PR comparison tests.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8443e67 into cms-sw:CMSSW_11_0_X Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants