Fix bug in PoolSource when skipping events with a missing file #29031
Conversation
If the configuration has N input files and skipEvents causes us to skip N-1 files and the last file can not be opened, the job would crash.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29031/13894
|
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: IOPool/Input @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
please test |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
The tests are being triggered in jenkins. |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
1 similar comment
|
Comparison is ready Comparison Summary:
|
|
+1 |
PR description:
If the configuration has N input files and skipEvents causes us to skip N-1 files and the last file can not be opened, the job would crash.
PR validation:
All framework unit tests pass.