Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of #28854 (Updates for Custom JME NanoAODs: Fix JetID, update modifiers and able to run on data) #29064

Conversation

nurfikri89
Copy link
Contributor

Backport of additions from #28854

This PR updates the Custom JME NanoAOD with the following items:

  1. Update era modifiers with run2_jme_2016 and run2_jme_2017.
  2. Setup the proper JetID versions according to PUPPI vs CHS for each year.
  3. Made necessary changes such that it can now run on data. Added wrapper functions to be used when specifying customise_commands when running on MC or data.

if this PR is a backport please specify the original PR:

Original PR is #28854

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/NanoAOD
PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @fgolf, @slava77, @santocch, @peruzzim can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @jdolen, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @clelange, @riga, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Mar 2, 2020

@nurfikri89 Please fix conflicts

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2020

Pull request #29064 was updated. @perrotta, @cmsbuild, @fgolf, @slava77, @santocch, @peruzzim can you please check and sign again.

@perrotta
Copy link
Contributor

perrotta commented Mar 2, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4950/console Started: 2020/03/02 12:38

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2020

+1
Tested at: 4330dc8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-08ccf6/4950/summary.html
CMSSW: CMSSW_10_6_X_2020-03-02-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-08ccf6/4950/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212324
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211988
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Mar 2, 2020

+1

@peruzzim
Copy link
Contributor

peruzzim commented Mar 2, 2020

+xpog

@silviodonato
Copy link
Contributor

+1

@santocch
Copy link

santocch commented Mar 3, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2020

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit d26fff8 into cms-sw:CMSSW_10_6_X Mar 3, 2020
@nurfikri89 nurfikri89 deleted the portFrom110XTo106X_nanojme_fixesAndupdateforData branch January 25, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants