Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid segfault in relval 50102 for gcc4.9.0 #2907

Merged
merged 1 commit into from Mar 17, 2014

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Mar 17, 2014

Relval test 50102 segfaults in gcc4.9.0 IB's. This segfault was traced to DQMOffline/Trigger/src/TopSingleLeptonHLTOfflineDQM.cc, where a vector subscript is way out of bounds (not an off-by-one error).
This pull request simply adds an assert to check for this and avoid the segfault. It is up to the package owners to fix the underlying problem.
Note that there is no segfault in relval 50102 in gcc4.8.1 IB's. Also, this assert does not fire in relval 50102 in gcc4.8.1 IB's. I did not investigate the difference. But again, the package owners need to diagnose and fix the problem before there can be releases using gcc4.9.0.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_1_X.

Avoid segfault in relval 50102 for gcc4.9.0

It involves the following packages:

DQMOffline/Trigger

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ojeda
Copy link

ojeda commented Mar 17, 2014

+1

Thanks for taking time investigating this, Bill.

ktf added a commit that referenced this pull request Mar 17, 2014
gcc 4.9.0 -- Avoid segfault in relval 50102 for gcc4.9.0
@ktf ktf merged commit 1e4c7f7 into cms-sw:CMSSW_7_1_X Mar 17, 2014
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@ktf
Copy link
Contributor

ktf commented Mar 17, 2014

I've bypassed tests, since it's trivial.

@wmtan wmtan deleted the AvoidSegfaultInRelval50102Forgcc490 branch March 17, 2014 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants