Avoid segfault in relval 50102 for gcc4.9.0 #2907
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relval test 50102 segfaults in gcc4.9.0 IB's. This segfault was traced to DQMOffline/Trigger/src/TopSingleLeptonHLTOfflineDQM.cc, where a vector subscript is way out of bounds (not an off-by-one error).
This pull request simply adds an assert to check for this and avoid the segfault. It is up to the package owners to fix the underlying problem.
Note that there is no segfault in relval 50102 in gcc4.8.1 IB's. Also, this assert does not fire in relval 50102 in gcc4.8.1 IB's. I did not investigate the difference. But again, the package owners need to diagnose and fix the problem before there can be releases using gcc4.9.0.