MTD Validation Update

[gsorrentino18]

PR description:

Two new plugins have been added to monitor and validate BTL and ETL reco clusters, cluster-track association and primary vertex time (@pmeridian @parbol).

PR validation:

The new code has been tested in the release CMSSW_11_1_X_2020-02-28-2300. The size of the new histograms on disk is:
569.70 KiB MTD/ETL
283.18 KiB MTD/BTL
compared with the previous size:
476.28 KiB MTD/ETL
234.96 KiB MTD/BTL

Some validation histograms for BTL and ETL reco objects:

BTL cluster time:

BTL cluster-track association efficiency as a function of eta:

BTL track time at the reference point:

ETL cluster time:

ETL cluster-track association efficiency as a function of phi:

Primary vertex time:

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29074/13954

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29074/13954/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29074/13954/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[jfernan2]

@gsorrentino18 can you please include yourself to the corresponding MTD Validation e-group in: https://twiki.cern.ch/twiki/bin/viewauth/CMS/DQMContacts#MTD

[jfernan2]

@gsorrentino18 there are code-check issues

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29074/13959

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @gsorrentino18 (Giulia Sorrentino) for master.

It involves the following packages:

Validation/Configuration
Validation/MtdValidation

@andrius-k, @kmaeshima, @schneiml, @civanch, @mdhildreth, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@apsallid, @rovere, @lecriste this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4965/console Started: 2020/03/03 15:38

[cmsbuild]

+1
Tested at: e846ecd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-de4146/4965/summary.html
CMSSW: CMSSW_11_1_X_2020-03-03-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-de4146/4965/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2680373
• DQMHistoTests: Total failures: 40
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2680014
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 566.568 KiB( 33 files compared)
• DQMHistoSizes: changed ( 20034.0,... ): 93.426 KiB MTD/ETL
• DQMHistoSizes: changed ( 20034.0,... ): 48.216 KiB MTD/BTL
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[civanch]

+1

[jfernan2]

+1
51 MEs added, all filled with entries

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1