Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add header guards for DYTThrObject.h and Serializable.h #29086

Merged
merged 1 commit into from Mar 16, 2020
Merged

Add header guards for DYTThrObject.h and Serializable.h #29086

merged 1 commit into from Mar 16, 2020

Conversation

oshadura
Copy link
Contributor

@oshadura oshadura commented Mar 3, 2020

For Serializable.h, we should change #pragma once, because it gets the filename and creates a include guard based on it. If it relocates it becomes problematic, because it is could be possible to have two files with the same name in two different locations.
(to avoid such cases we should rely less on #pragma once)

PR description:

This PR is a part of cms-sw/cmsdist#5600

cc: @davidlange6 @vgvassilev

@oshadura
Add header guards for DYTThrObject.h and Serializable.h
a7f78dc 
For Serializable.h, we should change #pragma once, because it gets the filename and creates a include guard based on it.
If it relocates it becomes problematic, because it is could be possible to have two files with the same name in two different locations.
(to avoid such cases we should rely less on #pragma once)
@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone Mar 3, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2020

The code-checks are being triggered in jenkins.

@vgvassilev
Copy link
Contributor

Part of #15248

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29086/13976

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2020

A new Pull Request was created by @oshadura (Oksana Shadura) for master.

It involves the following packages:

CondFormats/RecoMuonObjects
CondFormats/Serialization

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2020 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4976/console Started: 2020/03/03 18:05

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2020

+1
Tested at: a7f78dc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a01e33/4976/summary.html
CMSSW: CMSSW_11_1_X_2020-03-03-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a01e33/4976/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2680373
  • DQMHistoTests: Total failures: 41
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2680013
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@mrodozov
Copy link
Contributor

mrodozov commented Mar 4, 2020

@oshadura is it because of this missing the 5600 is failing ? in other words should we test 5600 along with this by default ?

@oshadura
Copy link
Contributor Author

oshadura commented Mar 4, 2020

@mrodozov yup! it should go together, sorry for late notice!

@oshadura oshadura mentioned this pull request Mar 4, 2020
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2020 •
edited

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5600
Test Parameters:

@davidlange6
Copy link
Contributor

the 'requires external' label isn't really appropriate here... the external PR requires this PR, but this PR does not require the external PR.

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2020 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5017/console Started: 2020/03/05 20:31

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2020

+1
Tested at: a7f78dc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a01e33/5017/summary.html
CMSSW: CMSSW_11_1_X_2020-03-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a01e33/5017/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2680577
  • DQMHistoTests: Total failures: 40
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2680218
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@pohsun
Copy link

pohsun commented Mar 6, 2020

+1

@davidlange6
Copy link
Contributor

hi @ggovi, all - any further comments on this PR?

@davidlange6
Copy link
Contributor

seems not - could we move on with this PR?

@silviodonato
Copy link
Contributor

@ggovi I'm going to integrate this PR in the next IB. Please let me know if you have objections.

@silviodonato
Copy link
Contributor

merge
In case you have any comments, please let me know

@cmsbuild cmsbuild merged commit e38d6f2 into cms-sw:master Mar 16, 2020
@cmsbuild cmsbuild mentioned this pull request Mar 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved code-checks-approved comparison-available db-pending orp-approved pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_11_1_X
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@oshadura @cmsbuild @vgvassilev @davidlange6 @mrodozov @pohsun @silviodonato