New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "PPS: rename directories with misleading names" #29093
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29093/13986
|
A new Pull Request was created by @silviodonato (Silvio Donato) for master. It involves the following packages: CalibPPS/ESProducers The following packages do not have a category, yet: CondFormats/PPSObjects @andrius-k, @schneiml, @ianna, @fioriNTU, @tlampen, @pohsun, @santocch, @perrotta, @civanch, @makortel, @cmsbuild, @davidlange6, @Dr15Jones, @cvuosalo, @mdhildreth, @jfernan2, @tocheng, @slava77, @ggovi, @fabiocos, @kmaeshima, @christopheralanwest, @silviodonato, @franzoni can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@silviodonato : are you planning to revert #29093? As far as I can see, there are a few unit tests which fail with some related message, e.g.:
The CondFormats/CTPPSReadoutObjects package does not exist any more after that PR, and so should its library. The issue must be related to what described by @Dr15Jones in #29037 (comment) |
is this related to the failing tests ? |
merge |
@pcanal could you comment about the new ROOT warning? Our guess is ROOT is checking all directories listed in LD_LIBRARY_PATH for root map files even if a given library is found multiple directories in the environment variable. |
Yes, ROOT looks in all directories in LD_LIBRARY_PATH for rootmap files.
There seems to be protection against that in the code ... or more exactly the duplicate avoidance is base in the rootmap filename. Note that in the example above it does complains (3 different time) about 2 distincts libraries. |
+1 |
1 similar comment
+1 |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
Pull request #29093 was updated. @perrotta, @rappoccio, @vlimant, @consuegs, @mdhildreth, @saumyaphor4252, @civanch, @simonepigazzini, @antoniovilela, @francescobrivio, @fabiocos, @davidlange6 can you please check and sign again. |
Reverts #29037