Run3-TB51 Correct the beam momentum generator for HGCal TB studies

[bsunanda]

PR description:

Correct the beam generator used for HGCal TB studies and update the analyzer to take the beam dependent parameters

PR validation:

Use the cfg files in SimG4CMS/HGCalTestBeam/test

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29114/14018

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29114/14018/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29114/14018/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29114/14021

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

IOMC/ParticleGuns
SimG4CMS/HGCalTestBeam

@SiewYan, @efeyazgan, @mkirsano, @civanch, @mdhildreth, @cmsbuild, @agrohsje, @kpedro88, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@makortel, @rovere this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5013/console Started: 2020/03/05 18:35

[cmsbuild]

+1
Tested at: 5fb8530
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-584419/5013/summary.html
CMSSW: CMSSW_11_1_X_2020-03-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Pull request #29114 was updated. @SiewYan, @efeyazgan, @mkirsano, @civanch, @mdhildreth, @cmsbuild, @agrohsje, @kpedro88, @alberto-sanchez, @qliphy can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5083/console Started: 2020/03/09 19:42

[cmsbuild]

+1
Tested at: 2f5fb2c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-584419/5083/summary.html
CMSSW: CMSSW_11_1_X_2020-03-09-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-584419/5083/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2680577
• DQMHistoTests: Total failures: 39
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2680219
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[kpedro88]

+upgrade

[civanch]

+1

[agrohsje]

@kpedro88 is your proposal to use the existing functions strict or not, i.e. is it just a proposal? Waiting for this before signing.

[kpedro88]

@agrohsje the PR was updated to use the deltaPhi functions where appropriate (some of the cases are slightly outside the scope of what is available centrally)

[agrohsje]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1