Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HCAL zero suppression condition for Run 3 #29140

Merged
merged 1 commit into from Mar 7, 2020

Conversation

christopheralanwest
Copy link
Contributor

@christopheralanwest christopheralanwest commented Mar 6, 2020

PR description:

The DB tag specifying the HCAL zero suppression is updated for all Run 3 scenarios. Currently the HCAL zero suppression is calculated using two ADC samples but this PR switches to using only one sample.

This change will also need to be applied to the new 2021 heavy ion GT introduced in PR #29078. To avoid potential conflicts, I will update that PR with the modified ZS after this PR is merged.

The diffs of the updated GTs with respect to the previous are as follows:

2021 pp collision design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun3_2021_design_v6/111X_mcRun3_2021_design_v1

2021 pp collision realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun3_2021_realistic_v8/111X_mcRun3_2021_realistic_v1

2021 cosmic realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun3_2021cosmics_realistic_deco_v5/111X_mcRun3_2021cosmics_realistic_deco_v1

2023 pp collision realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun3_2023_realistic_v8/111X_mcRun3_2023_realistic_v1

2024 pp collision realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun3_2024_realistic_v8/111X_mcRun3_2024_realistic_v1

PR validation:

In addition, a technical test was performed: runTheMatrix.py -l limited,12024.0,7.23,12834.0 --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport and should not be backported.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29140/14066

  • This PR adds an extra 12KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2020

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

Configuration/AlCa

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor Author

test parameters
workflow = 12024.0,7.23,12834.0

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2020

+1
Tested at: a2fb0e5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b9d19/5049/summary.html
CMSSW: CMSSW_11_1_X_2020-03-06-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b9d19/5049/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5b9d19/12024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2021Design_GenSimFull+DigiFull_2021Design+RecoFull_2021Design+HARVESTFull_2021Design
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5b9d19/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2229 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2680577
  • DQMHistoTests: Total failures: 16339
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2663919
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@christopheralanwest
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@abdoulline
Copy link

@christopheralanwest thank you, Chris!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants