New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HCAL zero suppression condition for Run 3 #29140
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29140/14066
|
A new Pull Request was created by @christopheralanwest for master. It involves the following packages: Configuration/AlCa @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@christopheralanwest thank you, Chris! |
PR description:
The DB tag specifying the HCAL zero suppression is updated for all Run 3 scenarios. Currently the HCAL zero suppression is calculated using two ADC samples but this PR switches to using only one sample.
This change will also need to be applied to the new 2021 heavy ion GT introduced in PR #29078. To avoid potential conflicts, I will update that PR with the modified ZS after this PR is merged.
The diffs of the updated GTs with respect to the previous are as follows:
2021 pp collision design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun3_2021_design_v6/111X_mcRun3_2021_design_v1
2021 pp collision realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun3_2021_realistic_v8/111X_mcRun3_2021_realistic_v1
2021 cosmic realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun3_2021cosmics_realistic_deco_v5/111X_mcRun3_2021cosmics_realistic_deco_v1
2023 pp collision realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun3_2023_realistic_v8/111X_mcRun3_2023_realistic_v1
2024 pp collision realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun3_2024_realistic_v8/111X_mcRun3_2024_realistic_v1
PR validation:
In addition, a technical test was performed:
runTheMatrix.py -l limited,12024.0,7.23,12834.0 --ibeos
if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is not a backport and should not be backported.